From: Jeff Garzik <jeff@garzik.org>
To: Jeff Garzik <jeff@garzik.org>,
akpm@osdl.org, netdev@vger.kernel.org, jgarzik@pobox.com,
thockin@hockin.org
Subject: Re: [patch 3/9] natsemi: Add support for using MII port with no PHY
Date: Wed, 03 May 2006 07:07:12 -0400 [thread overview]
Message-ID: <44588EE0.5070307@garzik.org> (raw)
In-Reply-To: <20060428130139.GA20068@sirena.org.uk>
Mark Brown wrote:
> On Thu, Apr 27, 2006 at 05:54:58AM -0400, Jeff Garzik wrote:
>
>>> Provide a module option which configures the natsemi driver to use the
>>> external MII port on the chip but ignore any PHYs that may be attached to
>>> it. The link state will be left as it was when the driver started and can
>
>> The proper way to do this is via the force_media boolean flag found in
>> several net drivers.
>
> I've had a look at several of the net drivers that implement this option
> (e100, smc91x, starfire and the shared code in mii.c). Unless I'm
> misreading the code it looks like the effect of this option in those
> drivers is to disable autonegotiation but still configure the PHY when
> the NIC is configured.
>
> That is a subset of what the patch does and isn't sufficient for the
> hardware this patch targets: sometimes there may be a PHY visible on the
> MII bus but with a different configuration to the natsemi or there may
> be no PHY present at all. In this case the code in the natsemi driver
> that configures the PHY to match the configuration of the natsemi also
> needs to be disabled.
>
> It looks like I should implement a force_media option and redo this
> patch to use that.
That's the sort of patch I'm looking for...
Jeff
prev parent reply other threads:[~2006-05-03 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 9:30 [patch 3/9] natsemi: Add support for using MII port with no PHY akpm
2006-04-27 9:54 ` Jeff Garzik
2006-04-28 13:01 ` Mark Brown
2006-05-03 11:07 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44588EE0.5070307@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).