netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: netdev@vger.kernel.org
Subject: Very long list of struct dst_entry in dst_garbage_list
Date: Fri, 05 May 2006 18:13:30 +0200	[thread overview]
Message-ID: <445B79AA.7030209@cosmosbay.com> (raw)
In-Reply-To: <445B11A3.1020407@cosmosbay.com>

I noticed that after a 'ip route flush cache' (manual or timer 
triggered) on a busy server, XXXXX entries are added to dst_garbage_list.
(XXXXX depends on the number of established sockets)

Every 1/10th second (DST_GC_MIN) , net/core/dst.c::dst_run_gc() is 
fired, and try to free some entries from the list, but many entries have 
a non null refcnt and stay in the list for the next run.

Linux version is 2.6.17-rc3.

Do you think a rework of  dst_run_gc() function is necessary, (using a 
batch mode to limit the number of entries examined at each run), or is 
it a "should not happen, something is broken" situation ?

Eric




  parent reply	other threads:[~2006-05-05 16:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-03 21:19 latest -stable breaks Squid Dave Jones
2006-05-04  0:43 ` Dave Jones
2006-05-04  1:10 ` Herbert Xu
2006-05-04  1:22   ` Ben Greear
2006-05-04  1:59     ` Ian McDonald
2006-05-04 23:25       ` David S. Miller
2006-05-04 23:30         ` Herbert Xu
2006-05-04 23:47         ` Dave Jones
2006-05-05  8:49         ` [x86_64, NET] smp_rmb() in dst_destroy() seems very expensive, ditto in kfree_skb() Eric Dumazet
2006-05-05 10:06           ` Herbert Xu
2006-05-05 16:13           ` Eric Dumazet [this message]
2006-05-05 17:05           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445B79AA.7030209@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).