From: Brice Goglin <brice@myri.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Andrew J. Gallatin" <gallatin@myri.com>
Subject: Re: [PATCH 6/6] myri10ge - Kconfig and Makefile
Date: Sat, 13 May 2006 20:56:45 +0200 [thread overview]
Message-ID: <44662BED.5030000@myri.com> (raw)
In-Reply-To: <20060513185157.GC6931@stusta.de>
Adrian Bunk wrote:
> On Wed, May 10, 2006 at 11:43:55PM +0200, Brice Goglin wrote:
>
>> ...
>> --- linux-mm/drivers/net/Makefile.old 2006-04-08 04:49:53.000000000 -0700
>> +++ linux-mm/drivers/net/Makefile 2006-04-21 08:10:27.000000000 -0700
>> @@ -192,6 +192,7 @@ obj-$(CONFIG_R8169) += r8169.o
>> obj-$(CONFIG_AMD8111_ETH) += amd8111e.o
>> obj-$(CONFIG_IBMVETH) += ibmveth.o
>> obj-$(CONFIG_S2IO) += s2io.o
>> +obj-$(CONFIG_MYRI10GE) += myri10ge/
>> obj-$(CONFIG_SMC91X) += smc91x.o
>> obj-$(CONFIG_SMC911X) += smc911x.o
>> obj-$(CONFIG_DM9000) += dm9000.o
>> --- /dev/null 2006-04-21 00:45:09.064430000 -0700
>> +++ linux-mm/drivers/net/myri10ge/Makefile 2006-04-21 08:14:21.000000000 -0700
>> @@ -0,0 +1,5 @@
>> +#
>> +# Makefile for the Myricom Myri-10G ethernet driver
>> +#
>> +
>> +obj-$(CONFIG_MYRI10GE) += myri10ge.o
>>
>
> If the driver consists of one source file, why does it need an own
> subdir?
>
> cu
> Adrian
>
We also have 2 header files. But, I am fine with putting our 3 files in
drivers/net/ instead.
Brice
prev parent reply other threads:[~2006-05-13 19:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 21:22 [PATCH 0/6] myri10ge - Myri-10G Ethernet driver Brice Goglin
2006-05-10 21:34 ` [PATCH 1/6] myri10ge - Revive pci_find_ext_capability Brice Goglin
2006-05-10 21:35 ` [PATCH 2/6] myri10ge - Add missing PCI IDs Brice Goglin
2006-05-10 21:52 ` Andi Kleen
2006-05-10 21:36 ` [PATCH 3/6] myri10ge - Driver header files Brice Goglin
2006-05-10 21:57 ` Roland Dreier
2006-05-10 22:00 ` Stephen Hemminger
2006-05-10 22:02 ` Francois Romieu
2006-05-10 21:40 ` [PATCH 4/6] myri10ge - First half of the driver Brice Goglin
2006-05-10 22:01 ` Stephen Hemminger
2006-05-10 22:06 ` Roland Dreier
2006-05-10 22:04 ` Roland Dreier
2006-05-11 23:53 ` Brice Goglin
2006-05-10 23:13 ` Francois Romieu
2006-05-11 23:53 ` Brice Goglin
2006-05-12 6:47 ` Evgeniy Polyakov
2006-05-12 17:40 ` David S. Miller
2006-05-13 16:13 ` Francois Romieu
2006-05-15 17:02 ` Lee Revell
2006-05-15 17:39 ` Brice Goglin
2006-05-10 21:42 ` [PATCH 5/6] myri10ge - Second " Brice Goglin
2006-05-10 22:22 ` Stephen Hemminger
[not found] ` <200605111924.33125.netdev@axxeo.de>
2006-05-11 18:28 ` [PATCH] expose simplified skb_checksum_recalc Stephen Hemminger
2006-05-11 18:40 ` Ingo Oeser
2006-05-12 19:52 ` David S. Miller
2006-05-11 23:53 ` [PATCH 5/6] myri10ge - Second half of the driver Brice Goglin
2006-05-12 0:31 ` Herbert Xu
2006-05-10 21:43 ` [PATCH 6/6] myri10ge - Kconfig and Makefile Brice Goglin
2006-05-13 18:51 ` Adrian Bunk
2006-05-13 18:56 ` Brice Goglin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44662BED.5030000@myri.com \
--to=brice@myri.com \
--cc=bunk@stusta.de \
--cc=gallatin@myri.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).