From: Auke Kok <auke-jan.h.kok@intel.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
John Rociak <john.ronciak@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH 02/11] ixgb: Fix the use of dprintk rather than printk
Date: Fri, 19 May 2006 11:35:34 -0700 [thread overview]
Message-ID: <446E0FF6.90307@intel.com> (raw)
In-Reply-To: <20060422090301.GB26666@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Jeff Kirsher <jeffrey.t.kirsher@intel.com> :
>> @@ -486,8 +495,7 @@ ixgb_probe(struct pci_dev *pdev,
>> netif_carrier_off(netdev);
>> netif_stop_queue(netdev);
>>
>> - printk(KERN_INFO "%s: Intel(R) PRO/10GbE Network Connection\n",
>> - netdev->name);
>> + DPRINTK(PROBE, INFO, "Intel(R) PRO/10GbE Network Connection\n");
>
> It could probably be factored out with ixgb_driver_string.
the driver name is different from the interface/device that it drives - Hence
the different name. The 'Connection' name as above is the branding name as
well, and that's why we print it here as such. e1000 does the same thing for
the same reason.
Auke
next prev parent reply other threads:[~2006-05-19 18:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-22 1:00 [PATCH 00/11] ixgb: driver update (upstream) Jeff Kirsher
2006-04-22 1:00 ` [PATCH 01/11] ixgb: Fix compilation errors by initializing variables Jeff Kirsher
2006-04-22 8:49 ` Francois Romieu
2006-04-22 1:00 ` [PATCH 02/11] ixgb: Fix the use of dprintk rather than printk Jeff Kirsher
2006-04-22 9:03 ` Francois Romieu
2006-04-24 17:24 ` Stephen Hemminger
2006-05-19 18:35 ` Auke Kok [this message]
2006-04-22 1:00 ` [PATCH 03/11] ixgb: Fix hard coded numbers Jeff Kirsher
2006-04-22 9:17 ` Francois Romieu
2006-04-22 1:00 ` [PATCH 04/11] ixgb: Fix duplicate code Jeff Kirsher
2006-04-22 1:00 ` [PATCH 05/11] ixgb: Fix timeout code Jeff Kirsher
2006-04-22 1:00 ` [PATCH 06/11] ixgb: Fix TSO Jeff Kirsher
2006-04-22 1:00 ` [PATCH 07/11] ixgb: Fixed flow control parameters Jeff Kirsher
2006-04-22 1:00 ` [PATCH 08/11] ixgb: Add support for copper 10GbE Jeff Kirsher
2006-04-22 1:00 ` [PATCH 09/11] ixgb: Add performance enhancements to the buffer_info struct Jeff Kirsher
2006-04-22 1:00 ` [PATCH 10/11] ixgb: clean up whitespace Jeff Kirsher
2006-04-22 1:00 ` [PATCH 11/11] ixgb: Add prefetch Jeff Kirsher
2006-04-22 5:34 ` Eric Dumazet
2006-04-26 10:22 ` [PATCH 00/11] ixgb: driver update (upstream) Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446E0FF6.90307@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).