From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.35 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795157928; b=wFzfzv/z2Nc4lbluzabrWHwB1j2jUpykGsCj3QPjbZEdzIKgsCzt/wr5jUgmo77qOL22 OiAtTEjyfM/MeHcTVgoCFa3Cyjgx9iBAlob3TFjuQky1e6XlGmf7OE/JGCwDTvnqVeknF 0I8IyIA928oSnWf09ft0hoRvzRkxz24NGxrtlmrF+RB4jcP99CkQRwWGjn9tZ+EA9ehk4 x0GfZUJ97F4STNuJ8Y6qdaMKfjCEbeZ+myfLc89BiPUfIYLds9N7Dnf0RYnwm1+pgMsWL 12eKWPfnbrcBDB10D+d8y4MnWHL9HYQQgKBpbnWmCuG+AUzsqbjgAlxiq0SQA3HWPHg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795157928; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=D7mHdJTvEsH8KV6HnKZGTk0iLCumja+GPMGSkHUssA0=; b=3BHb4Cp7yolZLHQ8UHGc0qBWilpgS/RmCdOnoqqSGssKTvTzNwQnXH+ATReqfc3LDcas cHTXFt1Jq4UvQCHD0FZb9wm+PFqx4xQpBQBcs6PMbtBUU7tRLPejtojAdYMihgx19doXP rAz79SoDT92qGD7jQErJR7C91WY5BBtCgSMBaBrPOudhq+AB+Mx8ZmXx4ZUttfOZyQR6f lB0UfjvYs6oaudPXVkSfAx7sLSGsHHM8M4H4M64V6Hz6evYCrr0/zIQjgq0Pgli1VH7cm 8TUVM0WfQy94Ji9bhHIDW0S8jsyjFYsY6UiYvkGurNyl1KjLQ7DsAUROlc++Hu3PGSg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=lh4XfjGQ; arc=none smtp.remote-ip=95.215.58.35 Received: from mta1.migadu.com (out-35.mta1.migadu.com [95.215.58.35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8AE606A326 for ; Fri, 20 Nov 2026 06:58:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DA8AE606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=lh4XfjGQ X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=pDDU+0D383chdCIpoFHHlcrvgVEBH5dnlyFCoSq0GdY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795157926; v=1; x=1795762726; b=lh4XfjGQOQ8KMCLQjOs7mTV5ZcQaPIktvZSmmRvqnPqKmooZxOV1brSWODCWw2wpLg3kuEWx 6i37+ADOHVinvpcFkXW5JzJmg08TpTxxayH6HI427LR2/+5tjQsDQGnMeZrpArmBKXTuM0aO/NI mzee2lYCqqbcDeg7WyT7njE4= X-Envelope-To: netdev@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id b614ed43f9ab845e; Fri, 20 Nov 2026 06:58:45 +0000 X-Mizu-Trace-ID: b614ed43f9ab845e X-Migadu-Flow: FLOW_OUT Message-ID: <4472929f-04ec-4a00-a872-f4a537b3ca53@linux.dev> Date: Fri, 20 Nov 2026 07:58:44 +0100 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 14/24] net: dsa: rzn1-a5psw: Make use dev_err_probe() To: Prabhakar , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Russell King , Simon Horman , Philipp Zabel , Geert Uytterhoeven , Magnus Damm Cc: Florian Fainelli , Ralph Siemsen , linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar References: <20261120002549.1908299-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20261120002549.1908299-15-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Language: en-US From: Clement Leger In-Reply-To: <20261120002549.1908299-15-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/20/26 01:25, Prabhakar wrote: > From: Lad Prabhakar > > Replace dev_err() with dev_err_probe() when reporting failures from > devm_clk_get_enabled(). Clock retrieval may legitimately return > -EPROBE_DEFER, and the current use of dev_err() incorrectly reports > such cases as hard errors. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Lad Prabhakar > --- > v4->v5: > - No change > > v3->v4: > - No change > > v2->v3: > - No change > > v1->v2: > - New patch > --- > drivers/net/dsa/rzn1_a5psw.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c > index 4b31a1d331e1..bccfadc1d5e6 100644 > --- a/drivers/net/dsa/rzn1_a5psw.c > +++ b/drivers/net/dsa/rzn1_a5psw.c > @@ -1240,15 +1240,15 @@ static int a5psw_probe(struct platform_device *pdev) > > a5psw->hclk = devm_clk_get_enabled(dev, "hclk"); > if (IS_ERR(a5psw->hclk)) { > - dev_err(dev, "failed get hclk clock\n"); > ret = PTR_ERR(a5psw->hclk); > + dev_err_probe(dev, ret, "failed get hclk clock\n"); > goto free_pcs; > } > > a5psw->clk = devm_clk_get_enabled(dev, "clk"); > if (IS_ERR(a5psw->clk)) { > - dev_err(dev, "failed get clk_switch clock\n"); > ret = PTR_ERR(a5psw->clk); > + dev_err_probe(dev, ret, "failed get clk_switch clock\n"); > goto free_pcs; > } > Hi Prabhakar, LGTM, Reviewed-by: Clément Léger Thanks, Clément