netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Auke Kok <auke-jan.h.kok@intel.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@osdl.org>,
	netdev@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH] e1000: endian fixes
Date: Tue, 23 May 2006 14:30:45 -0700	[thread overview]
Message-ID: <44737F05.40308@intel.com> (raw)
In-Reply-To: <20060515225432.GG10143@mipter.zuzino.mipt.ru>


Ack, please apply and add my acked-by/signed-off-by.

Cheers,

Auke


---
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>


Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  drivers/net/e1000/e1000_main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- 1/drivers/net/e1000/e1000_main.c
> +++ 1/drivers/net/e1000/e1000_main.c
> @@ -2451,7 +2451,7 @@ e1000_tso(struct e1000_adapter *adapter,
>  
>  		hdr_len = ((skb->h.raw - skb->data) + (skb->h.th->doff << 2));
>  		mss = skb_shinfo(skb)->tso_size;
> -		if (skb->protocol == ntohs(ETH_P_IP)) {
> +		if (skb->protocol == htons(ETH_P_IP)) {
>  			skb->nh.iph->tot_len = 0;
>  			skb->nh.iph->check = 0;
>  			skb->h.th->check =
> @@ -2930,7 +2930,7 @@ e1000_xmit_frame(struct sk_buff *skb, st
>  	/* Old method was to assume IPv4 packet by default if TSO was enabled.
>  	 * 82571 hardware supports TSO capabilities for IPv6 as well...
>  	 * no longer assume, we must. */
> -	if (likely(skb->protocol == ntohs(ETH_P_IP)))
> +	if (likely(skb->protocol == htons(ETH_P_IP)))
>  		tx_flags |= E1000_TX_FLAGS_IPV4;
>  
>  	e1000_tx_queue(adapter, tx_ring, tx_flags,
> 
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


      reply	other threads:[~2006-05-23 21:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-15 22:54 [PATCH] e1000: endian fixes Alexey Dobriyan
2006-05-23 21:30 ` Auke Kok [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44737F05.40308@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).