* [-mm patch] drivers/net/s2io.c: make bus_speed[] static [not found] <20060515005637.00b54560.akpm@osdl.org> @ 2006-05-16 15:30 ` Adrian Bunk 2006-05-16 15:36 ` Andreas Mohr 2006-05-24 5:28 ` Jeff Garzik 0 siblings, 2 replies; 4+ messages in thread From: Adrian Bunk @ 2006-05-16 15:30 UTC (permalink / raw) To: Andrew Morton, Ananda Raju, jgarzik; +Cc: linux-kernel, netdev On Mon, May 15, 2006 at 12:56:37AM -0700, Andrew Morton wrote: >... > Changes since 2.6.17-rc3-mm1: >... > git-netdev-all.patch >... > git trees >... This patch makes the needlessly global bus_speed[] static. Signed-off-by: Adrian Bunk <bunk@stusta.de> --- linux-2.6.17-rc4-mm1-full/drivers/net/s2io.c.old 2006-05-16 13:06:58.000000000 +0200 +++ linux-2.6.17-rc4-mm1-full/drivers/net/s2io.c 2006-05-16 13:07:08.000000000 +0200 @@ -852,7 +852,7 @@ return 0; } -int bus_speed[8] = {33, 133, 133, 200, 266, 133, 200, 266}; +static int bus_speed[8] = {33, 133, 133, 200, 266, 133, 200, 266}; /** * s2io_print_pci_mode - */ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [-mm patch] drivers/net/s2io.c: make bus_speed[] static 2006-05-16 15:30 ` [-mm patch] drivers/net/s2io.c: make bus_speed[] static Adrian Bunk @ 2006-05-16 15:36 ` Andreas Mohr 2006-05-16 16:42 ` Adrian Bunk 2006-05-24 5:28 ` Jeff Garzik 1 sibling, 1 reply; 4+ messages in thread From: Andreas Mohr @ 2006-05-16 15:36 UTC (permalink / raw) To: Adrian Bunk; +Cc: Andrew Morton, Ananda Raju, jgarzik, linux-kernel, netdev Hi, On Tue, May 16, 2006 at 05:30:50PM +0200, Adrian Bunk wrote: > This patch makes the needlessly global bus_speed[] static. Is there a reason why you don't also constify it while you are at it? Or is it because you want to do a series of static-only patches for now? Andreas Mohr ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [-mm patch] drivers/net/s2io.c: make bus_speed[] static 2006-05-16 15:36 ` Andreas Mohr @ 2006-05-16 16:42 ` Adrian Bunk 0 siblings, 0 replies; 4+ messages in thread From: Adrian Bunk @ 2006-05-16 16:42 UTC (permalink / raw) To: Andreas Mohr; +Cc: Andrew Morton, Ananda Raju, jgarzik, linux-kernel, netdev On Tue, May 16, 2006 at 05:36:11PM +0200, Andreas Mohr wrote: > Hi, > > On Tue, May 16, 2006 at 05:30:50PM +0200, Adrian Bunk wrote: > > This patch makes the needlessly global bus_speed[] static. > > Is there a reason why you don't also constify it while you are at it? > Or is it because you want to do a series of static-only patches for now? The latter. Feel free to send a patch that also makes it const. > Andreas Mohr cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [-mm patch] drivers/net/s2io.c: make bus_speed[] static 2006-05-16 15:30 ` [-mm patch] drivers/net/s2io.c: make bus_speed[] static Adrian Bunk 2006-05-16 15:36 ` Andreas Mohr @ 2006-05-24 5:28 ` Jeff Garzik 1 sibling, 0 replies; 4+ messages in thread From: Jeff Garzik @ 2006-05-24 5:28 UTC (permalink / raw) To: Adrian Bunk; +Cc: Andrew Morton, Ananda Raju, linux-kernel, netdev Adrian Bunk wrote: > On Mon, May 15, 2006 at 12:56:37AM -0700, Andrew Morton wrote: >> ... >> Changes since 2.6.17-rc3-mm1: >> ... >> git-netdev-all.patch >> ... >> git trees >> ... > > > This patch makes the needlessly global bus_speed[] static. > > Signed-off-by: Adrian Bunk <bunk@stusta.de> applied ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-05-24 5:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060515005637.00b54560.akpm@osdl.org>
2006-05-16 15:30 ` [-mm patch] drivers/net/s2io.c: make bus_speed[] static Adrian Bunk
2006-05-16 15:36 ` Andreas Mohr
2006-05-16 16:42 ` Adrian Bunk
2006-05-24 5:28 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).