[RFC] new qla3xxx NIC Driver v2.02.00k29

[RFC] new qla3xxx NIC Driver v2.02.00k29

[Ron Mercer]

All,

Third submission for the upstream inclusion of the qla3xxx Ethernet
driver. This is a complementary network driver for our ISP4XXX parts.
There is a concurrent effort underway to get the iSCSI driver (qla4xxx)
integrated upstream as well.

The following files are included and have been posted to the link below:

LICENSE.qla3xxx
qla3xxxsrc-v2.02.00k29.tgz

ftp://ftp.qlogic.com/network/upstream/20.02.00k29/

Second submission:
http://marc.theaimsgroup.com/?l=linux-netdev&m=114780280407707&w=2

Comments from second submission:
http://marc.theaimsgroup.com/?l=linux-netdev&m=114782208808695&w=2



Changes in this release:
- Reordered code to remove forward declarations.
- Removed typedefs.
- Changed inter-driver hardware lock to use wait_event().
- Removed macros defined inside structure definitions.
- Removed volatile usage.
- Removed wrapper RD_REG_READ/WRITE macros for readl/writel
- Bug fix for msi logic.
- Removed unused debug print functions.
- probe now propagates error codes from api to caller.
- Removed internal send queue and lock dependency.


Looking forward to any and all feedback.

Regards,

Ron Mercer
Qlogic Corporation

Re: [RFC] new qla3xxx NIC Driver v2.02.00k29

[Jeff Garzik]

Ron Mercer wrote:
> All,
> 
> Third submission for the upstream inclusion of the qla3xxx Ethernet
> driver. This is a complementary network driver for our ISP4XXX parts.
> There is a concurrent effort underway to get the iSCSI driver (qla4xxx)
> integrated upstream as well.
> 
> The following files are included and have been posted to the link below:
> 
> LICENSE.qla3xxx
> qla3xxxsrc-v2.02.00k29.tgz
> 
> ftp://ftp.qlogic.com/network/upstream/20.02.00k29/

Two points:

1) the ftp:// URL doesn't work for me.

2) Why do we need another license?

	Jeff

Re: [RFC] new qla3xxx NIC Driver v2.02.00k29

[Andrew Vasquez]

On Wed, 24 May 2006, Jeff Garzik wrote:

> >Third submission for the upstream inclusion of the qla3xxx Ethernet
> >driver. This is a complementary network driver for our ISP4XXX parts.
> >There is a concurrent effort underway to get the iSCSI driver (qla4xxx)
> >integrated upstream as well.
> >
> >The following files are included and have been posted to the link below:
> >
> >LICENSE.qla3xxx
> >qla3xxxsrc-v2.02.00k29.tgz
> >
> >ftp://ftp.qlogic.com/network/upstream/20.02.00k29/
> 
> Two points:
> 
> 1) the ftp:// URL doesn't work for me.

that should have read as:

ftp://ftp.qlogic.com/outgoing/linux/network/upstream/20.02.00k29/qla3xxxsrc-v2.02.00-k29.tgz

> 2) Why do we need another license?

I believe he is referring to this one:

ftp://ftp.qlogic.com/outgoing/linux/network/upstream/2.02.00k19/LICENSE.qla3xxx

which is QLogic's boiler-plate license for drivers which support
hardware that can potentially be programmed with an external firmware
blob.  In this case, the QLA3xxx boards currently run with the
'onboard' firmware image.  Above and beyond the standard GPL licencing
of the driver sources, the license goes further and states that any
firmware-blob will be licensed under the three-clause BSD license.

This is similar to QLogic's FC driver:

http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;h=9e15b4f9cd289f116a1448986847a6313d13bf5f;hb=a8bd60705aa17a998516837d9c1e503ad4cbd7fc;f=Documentation/scsi/LICENSE.qla2xxx

--
av