netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Phil Dibowitz <phil@ipom.com>
Cc: Rick Jones <rick.jones2@hp.com>, jamal <hadi@cyberus.ca>,
	netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
	Jeff Garzik <jeff@garzik.org>
Subject: Re: reminder, 2.6.18 window...
Date: Thu, 25 May 2006 00:18:31 -0700	[thread overview]
Message-ID: <44755A47.3030405@candelatech.com> (raw)
In-Reply-To: <44753A3B.5010204@ipom.com>

Phil Dibowitz wrote:

> As for the clearing, in this case, the clearing is done by a command to
> the hardware - and I believe the hardware does that atomically. However,
> I could certainly add a spinlock around it if someone sees a need.

No, because then you'd also have to add the spin-lock in the hot path
to keep rx/tx threads from accessing counters at the same time.  There is no
way a patch that hurts performance like this will be accepted, but I'm
still hopeful that a patch with zero or very near zero performance impact
will be accepted.

Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2006-05-25  7:19 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-24  1:22 reminder, 2.6.18 window David Miller
2006-05-24  8:01 ` Phil Dibowitz
2006-05-24 18:21   ` jamal
2006-05-24 18:23   ` Jeff Garzik
2006-05-24 18:34     ` Rick Jones
2006-05-24 18:56     ` Phil Dibowitz
2006-05-24 19:05       ` Jeff Garzik
2006-05-24 19:14         ` Phil Dibowitz
2006-05-24 20:01           ` Brent Cook
2006-05-24 20:08             ` Jeff Garzik
2006-05-25  7:23               ` Bill Fink
2006-05-25 13:05                 ` Brent Cook
2006-05-25 16:12                   ` Bill Fink
2006-05-25 17:59                   ` Phil Dibowitz
2006-05-25 18:41                     ` Brent Cook
2006-05-25 19:22                       ` Phil Dibowitz
2006-05-25 20:29                         ` David Miller
2006-05-25 21:04                           ` Phil Dibowitz
2006-05-25 21:07                             ` David Miller
2006-05-26  9:52                   ` Andi Kleen
2006-05-25 13:34                 ` Dave Dillow
2006-05-26  9:46               ` Andi Kleen
2006-05-24 20:10           ` jamal
2006-05-24 20:25             ` Rick Jones
2006-05-25 15:27               ` jamal
2006-05-25 16:43                 ` Rick Jones
2006-05-26 22:06                   ` Rick Jones
2006-05-24 20:44             ` Brian Haley
2006-05-24 21:01               ` Rick Jones
2006-05-26  6:48               ` Phil Dibowitz
2006-05-24 20:48             ` Phil Dibowitz
2006-05-24 21:04               ` Rick Jones
2006-05-24 21:10                 ` Ben Greear
2006-05-25  5:01                   ` Phil Dibowitz
2006-05-25  7:18                     ` Ben Greear [this message]
2006-05-25  7:55                     ` Bill Fink
2006-05-25 12:17                     ` Francois Romieu
2006-05-25  9:53       ` Pekka Savola
2006-05-24 20:53     ` Andy
2006-05-26  9:43   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44755A47.3030405@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=phil@ipom.com \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).