netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* e1000: add WoL fix for 2.6.17rc
@ 2006-05-25 21:12 Auke Kok
  2006-05-27  1:32 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Auke Kok @ 2006-05-25 21:12 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: netdev, Jesse Brandeburg, Auke Kok, Kok, Auke

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]


Jeff,

Please queue the 'e1000: add shutdown handler back for WoL' for 2.6.17rc's. 
Since this fix is already committed to jgarzik/netdev-2.6#upstream, you can 
cherrypick it into #upstream-fixes:

$ git-cherry-pick c653e6351e371b33b29871e5eedf610ffb3be037


Cheers,

Auke

[-- Attachment #2: e1000_01_add_shutdown_back.patch --]
[-- Type: text/x-patch, Size: 1465 bytes --]

e1000: add shutdown handler back to fix WOL

Someone was waaay too aggressive and removed e1000's reboot notifier
instead of porting it to the new way of the shutdown handler.  This change
broke wake on lan.  Add the shutdown handler back in using the same method
as e100 uses.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>


diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index fb8cef6..b224e40 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -221,6 +221,7 @@ static void e1000_restore_vlan(struct e1
 static int e1000_suspend(struct pci_dev *pdev, pm_message_t state);
 static int e1000_resume(struct pci_dev *pdev);
 #endif
+static void e1000_shutdown(struct pci_dev *pdev);
 
 #ifdef CONFIG_NET_POLL_CONTROLLER
 /* for netdump / net console */
@@ -236,8 +237,9 @@ static struct pci_driver e1000_driver = 
 	/* Power Managment Hooks */
 #ifdef CONFIG_PM
 	.suspend  = e1000_suspend,
-	.resume   = e1000_resume
+	.resume   = e1000_resume,
 #endif
+	.shutdown = e1000_shutdown
 };
 
 MODULE_AUTHOR("Intel Corporation, <linux.nics@intel.com>");
@@ -4605,6 +4607,12 @@ e1000_resume(struct pci_dev *pdev)
 	return 0;
 }
 #endif
+
+static void e1000_shutdown(struct pci_dev *pdev)
+{
+	e1000_suspend(pdev, PMSG_SUSPEND);
+}
+
 #ifdef CONFIG_NET_POLL_CONTROLLER
 /*
  * Polling 'interrupt' - used by things like netconsole to send skbs

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: e1000: add WoL fix for 2.6.17rc
  2006-05-25 21:12 e1000: add WoL fix for 2.6.17rc Auke Kok
@ 2006-05-27  1:32 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-05-27  1:32 UTC (permalink / raw)
  To: Auke Kok; +Cc: netdev, Jesse Brandeburg, Kok, Auke

Auke Kok wrote:
> 
> Jeff,
> 
> Please queue the 'e1000: add shutdown handler back for WoL' for 
> 2.6.17rc's. Since this fix is already committed to 
> jgarzik/netdev-2.6#upstream, you can cherrypick it into #upstream-fixes:
> 
> $ git-cherry-pick c653e6351e371b33b29871e5eedf610ffb3be037

perfect, done, thanks.

	Jeff




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-05-27  1:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-25 21:12 e1000: add WoL fix for 2.6.17rc Auke Kok
2006-05-27  1:32 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).