From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device Date: Fri, 26 May 2006 12:53:36 +0159 Message-ID: <4476DE47.7010907@gmail.com> References: <20060526001053.D2349C7C58@atrey.karlin.mff.cuni.cz> <44764D4B.6050105@pobox.com> <4476D63E.8090207@gmail.com> <4476D6EC.4060501@pobox.com> <4476D95B.5030601@gmail.com> <4476DA5C.9080602@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Greg KH , Linux Kernel Mailing List , linux-pci@atrey.karlin.mff.cuni.cz, netdev@vger.kernel.org, mb@bu3sch.de, st3@riseup.net, linville@tuxdriver.com Return-path: Received: from nf-out-0910.google.com ([64.233.182.191]:19389 "EHLO nf-out-0910.google.com") by vger.kernel.org with ESMTP id S1751390AbWEZKyW (ORCPT ); Fri, 26 May 2006 06:54:22 -0400 Received: by nf-out-0910.google.com with SMTP id p48so34250nfa for ; Fri, 26 May 2006 03:54:21 -0700 (PDT) To: Jeff Garzik In-Reply-To: <4476DA5C.9080602@pobox.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jeff Garzik napsal(a): > The point is that you don't need to loop over the table, > pci_match_one_device() does that for you. The problem is, that there is no such function, I think. If you take a look at pci_dev_present: http://sosdg.org/~coywolf/lxr/source/drivers/pci/search.c#L270 They traverse the table in similar way as I do. pci_match_one_device() just checks (one to one) values without any looping. regards, - -- Jiri Slaby www.fi.muni.cz/~xslaby \_.-^-._ jirislaby@gmail.com _.-^-._/ B67499670407CE62ACC8 22A032CC55C339D47A7E -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFEdt5HMsxVwznUen4RAqt8AJ9pzaDey2zn399lrahelv17w8IiDgCguUwa 4xOX7pUX2Au/WBsbJbnNwBE= =P1cu -----END PGP SIGNATURE-----