From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netfilter-devel@lists.netfilter.org, netdev@vger.kernel.org,
Harald Welte <laforge@netfilter.org>
Subject: Re: [PATCH] ip_conntrack_helper_pptp.c: fix sstate/cstate typo
Date: Fri, 26 May 2006 16:38:43 +0200 [thread overview]
Message-ID: <447712F3.20008@trash.net> (raw)
In-Reply-To: <20060526122342.GB7267@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> --- a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
> +++ b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
> @@ -469,8 +469,8 @@ pptp_inbound_pkt(struct sk_buff **pskb,
> DEBUGP("%s but no session\n", pptp_msg_name[msg]);
> break;
> }
> - if (info->sstate != PPTP_CALL_IN_REP
> - && info->sstate != PPTP_CALL_IN_CONF) {
> + if (info->cstate != PPTP_CALL_IN_REP
> + && info->cstate != PPTP_CALL_IN_CONF) {
> DEBUGP("%s but never sent IN_CALL_REPLY\n",
> pptp_msg_name[msg]);
> break;
Looks correct to me, but I'm not that familiar with the code.
Harald, do you want me to apply this?
prev parent reply other threads:[~2006-05-26 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-26 12:23 [PATCH] ip_conntrack_helper_pptp.c: fix sstate/cstate typo Alexey Dobriyan
2006-05-26 14:38 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447712F3.20008@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=laforge@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).