* [PATCH] ip_conntrack_helper_pptp.c: fix sstate/cstate typo
@ 2006-05-26 12:23 Alexey Dobriyan
2006-05-26 14:38 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-05-26 12:23 UTC (permalink / raw)
To: netfilter-devel, netdev
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
--- a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
+++ b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
@@ -469,8 +469,8 @@ pptp_inbound_pkt(struct sk_buff **pskb,
DEBUGP("%s but no session\n", pptp_msg_name[msg]);
break;
}
- if (info->sstate != PPTP_CALL_IN_REP
- && info->sstate != PPTP_CALL_IN_CONF) {
+ if (info->cstate != PPTP_CALL_IN_REP
+ && info->cstate != PPTP_CALL_IN_CONF) {
DEBUGP("%s but never sent IN_CALL_REPLY\n",
pptp_msg_name[msg]);
break;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ip_conntrack_helper_pptp.c: fix sstate/cstate typo
2006-05-26 12:23 [PATCH] ip_conntrack_helper_pptp.c: fix sstate/cstate typo Alexey Dobriyan
@ 2006-05-26 14:38 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2006-05-26 14:38 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: netfilter-devel, netdev, Harald Welte
Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> --- a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
> +++ b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
> @@ -469,8 +469,8 @@ pptp_inbound_pkt(struct sk_buff **pskb,
> DEBUGP("%s but no session\n", pptp_msg_name[msg]);
> break;
> }
> - if (info->sstate != PPTP_CALL_IN_REP
> - && info->sstate != PPTP_CALL_IN_CONF) {
> + if (info->cstate != PPTP_CALL_IN_REP
> + && info->cstate != PPTP_CALL_IN_CONF) {
> DEBUGP("%s but never sent IN_CALL_REPLY\n",
> pptp_msg_name[msg]);
> break;
Looks correct to me, but I'm not that familiar with the code.
Harald, do you want me to apply this?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-26 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-26 12:23 [PATCH] ip_conntrack_helper_pptp.c: fix sstate/cstate typo Alexey Dobriyan
2006-05-26 14:38 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).