[PATCH] r8169: add new PCI ID

[PATCH] r8169: add new PCI ID

[Yoichi Yuasa]

Hi,

This patch add new PCI ID for r8169 driver.
RTL8110SBL has this PCI ID.

Please aply.

Yoichi

Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>

diff -pruN -X tb0287/Documentation/dontdiff tb0287-orig/drivers/net/r8169.c tb0287/drivers/net/r8169.c
--- tb0287-orig/drivers/net/r8169.c	2006-05-25 10:09:43.981416000 +0900
+++ tb0287/drivers/net/r8169.c	2006-05-25 09:58:45.932290500 +0900
@@ -184,6 +184,7 @@ static const struct {
 
 static struct pci_device_id rtl8169_pci_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8169), },
+	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8129), },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK,	0x4300), },
 	{ PCI_DEVICE(0x16ec,			0x0116), },
 	{ PCI_VENDOR_ID_LINKSYS,		0x1032, PCI_ANY_ID, 0x0024, },

Re: [PATCH] r8169: add new PCI ID

[Yoichi Yuasa]

On Sat, 27 May 2006 13:39:19 +0200
Francois Romieu <romieu@fr.zoreil.com> wrote:

> Jeff Garzik <jeff@garzik.org> :
> [...]
> > applied
> 
> $ grep 8129 drivers/net/*.[ch]
> [...]
> drivers/net/8139too.c:  {0x10ec, 0x8129, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }
> 
> Not a big issue but I would be really surprized that it does trigger
> a few PR.

me too, but it is true.
I have checked 2 chips of RTL8110SBL.
These chips work without any problem by the r8169 driver.

Yoichi

lspci result:
0000:01:02.0 0200: 10ec:8129 (rev 10)
	Subsystem: 11ec:8129
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 128 (8000ns min, 8000ns max), Cache Line Size: 0x08 (32 bytes)
	Interrupt: pin A routed to IRQ 53
	Region 0: I/O ports at 1000000 [size=256]
	Region 1: Memory at 11b00000 (32-bit, non-prefetchable) [size=256]
	Expansion ROM at 11c00000 [disabled] [size=32K]
	Capabilities: [dc] Power Management version 6
		Flags: PMEClk+ DSI+ D1- D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot-,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME+

0000:01:03.0 0200: 10ec:8129 (rev 10)
	Subsystem: 11ec:8129
	Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR- FastB2B-
	Status: Cap+ 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
	Latency: 128 (8000ns min, 8000ns max), Cache Line Size: 0x08 (32 bytes)
	Interrupt: pin A routed to IRQ 53
	Region 0: I/O ports at 1000400 [size=256]
	Region 1: Memory at 11b00100 (32-bit, non-prefetchable) [size=256]
	Expansion ROM at 11c08000 [disabled] [size=8K]
	Capabilities: [dc] Power Management version 1
		Flags: PMEClk+ DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2+,D3hot-,D3cold-)
		Status: D0 PME-Enable- DSel=0 DScale=0 PME-

Re: [PATCH] r8169: add new PCI ID

[Jeff Garzik]

Yoichi Yuasa wrote:
> Hi,
> 
> This patch add new PCI ID for r8169 driver.
> RTL8110SBL has this PCI ID.

applied

Re: [PATCH] r8169: add new PCI ID

[Francois Romieu]

Jeff Garzik <jeff@garzik.org> :
[...]
> applied

$ grep 8129 drivers/net/*.[ch]
[...]
drivers/net/8139too.c:  {0x10ec, 0x8129, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }

Not a big issue but I would be really surprized that it does trigger
a few PR.

-- 
Ueimor