[PATCH] Changes to ieee80211.h for user space regulatory daemon

[PATCH] Changes to ieee80211.h for user space regulatory daemon

[Larry Finger]

Attached are two small patches for include/net/ieee80211.h to prepare for later submission of code 
to implement a user-space daemon that supplies 802.11 regulatory information.

The first change adds a bit indicating that 802.11h rules are to be applied to a channel. As 
discussed earlier in this list, a single bit is unlikely to be sufficient; however, at this time I 
have been unable to find any regulations implementing differences between 802.11a and 802.11h other 
than DFS, radar detection and passive scanning. A single bit is thus sufficient to convey to the 
driver that these rules should be obeyed.

The second change adds comments to the freq and max_power fields of struct ieee80211_channel to 
indicate the units that are used.

Signed-Off-By: Larry Finger <Larry.Finger@lwfinger.net>

index 293e920..6a2f60c 100644
--- a/include/net/ieee80211.h
+++ b/include/net/ieee80211.h
@@ -968,6 +968,7 @@ #define IEEE80211_52GHZ_CHANNELS (IEEE80

  enum {
	IEEE80211_CH_PASSIVE_ONLY = (1 << 0),
+	IEEE80211_CH_80211H_RULES = (1 << 1),
	IEEE80211_CH_B_ONLY = (1 << 2),
	IEEE80211_CH_NO_IBSS = (1 << 3),
	IEEE80211_CH_UNIFORM_SPREADING = (1 << 4),
@@ -976,10 +977,10 @@ enum {
  };

  struct ieee80211_channel {
-	u32 freq;
+	u32 freq;	/* in MHz */
	u8 channel;
	u8 flags;
-	u8 max_power;
+	u8 max_power;	/* in dBm */
  };

  struct ieee80211_geo {

Re: [PATCH] Changes to ieee80211.h for user space regulatory daemon

[John W. Linville]

On Tue, May 30, 2006 at 11:55:42AM -0500, Larry Finger wrote:
> Attached are two small patches for include/net/ieee80211.h to prepare for 
> later submission of code to implement a user-space daemon that supplies 
> 802.11 regulatory information.
> 
> The first change adds a bit indicating that 802.11h rules are to be applied 
> to a channel. As discussed earlier in this list, a single bit is unlikely 

> @@ -968,6 +968,7 @@ #define IEEE80211_52GHZ_CHANNELS (IEEE80
> 
>  enum {
> 	IEEE80211_CH_PASSIVE_ONLY = (1 << 0),
> +	IEEE80211_CH_80211H_RULES = (1 << 1),
> 	IEEE80211_CH_B_ONLY = (1 << 2),
> 	IEEE80211_CH_NO_IBSS = (1 << 3),
> 	IEEE80211_CH_UNIFORM_SPREADING = (1 << 4),

Any idea why this "hole" was here to begin with?  Was there something
else defined as (1 << 1) previously?  Is it safe to reuse this value?

John
-- 
John W. Linville
linville@tuxdriver.com

Re: [PATCH] Changes to ieee80211.h for user space regulatory daemon

[Larry Finger]

John W. Linville wrote:
>> @@ -968,6 +968,7 @@ #define IEEE80211_52GHZ_CHANNELS (IEEE80
>>
>>  enum {
>> 	IEEE80211_CH_PASSIVE_ONLY = (1 << 0),
>> +	IEEE80211_CH_80211H_RULES = (1 << 1),
>> 	IEEE80211_CH_B_ONLY = (1 << 2),
>> 	IEEE80211_CH_NO_IBSS = (1 << 3),
>> 	IEEE80211_CH_UNIFORM_SPREADING = (1 << 4),
> 
> Any idea why this "hole" was here to begin with?  Was there something
> else defined as (1 << 1) previously?  Is it safe to reuse this value?
> 
> John

The hole has been there as long as I have been reading the ieee80211 code. If you are not 
comfortable with plugging the hole, then we can use (1 << 5).

Larry