netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: Marcelo Tosatti <marcelo@kvack.org>
Cc: Willy Tarreau <willy@w.ods.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Ayaz Abdulla <aabdulla@nvidia.com>
Subject: Re: [PATCH-2.4] forcedeth update to 0.50
Date: Wed, 31 May 2006 21:50:38 +0200	[thread overview]
Message-ID: <447DF38E.3020409@colorfullife.com> (raw)
In-Reply-To: <20060531180545.GA30797@dmt>

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

Marcelo Tosatti wrote:

>Since v2.4.33 should be out RSN, my opinion is that applying the one-liner 
>to fix the bringup problem for now is more prudent..
>
>  
>
It's attached. Untested, but it should work. Just the relevant hunk from 
the 0.42 patch.

But I would disagree with waiting for 2.3.34 for a full backport:
0.30 basically doesn't work, thus the update to 0.50 would be a big step 
forward - it can't be worse that 0.30.

--
    Manfred


[-- Attachment #2: patch-forcedeth-minimal --]
[-- Type: text/plain, Size: 461 bytes --]

--- 2.6/drivers/net/forcedeth.c	2005-08-14 11:17:03.000000000 +0200
+++ build-2.6/drivers/net/forcedeth.c	2005-08-14 11:16:53.000000000 +0200
@@ -2178,6 +2180,9 @@
 		writel(NVREG_MIISTAT_MASK, base + NvRegMIIStatus);
 		dprintk(KERN_INFO "startup: got 0x%08x.\n", miistat);
 	}
+	/* set linkspeed to invalid value, thus force nv_update_linkspeed
+	 * to init hw */
+	np->linkspeed = 0;
 	ret = nv_update_linkspeed(dev);
 	nv_start_rx(dev);
 	nv_start_tx(dev);

  reply	other threads:[~2006-05-31 19:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-30 22:03 [PATCH-2.4] forcedeth update to 0.50 Willy Tarreau
2006-05-31  5:50 ` Manfred Spraul
2006-05-31  5:54   ` Willy Tarreau
2006-05-31 18:05     ` Marcelo Tosatti
2006-05-31 19:50       ` Manfred Spraul [this message]
2006-05-31 19:43         ` Willy Tarreau
2006-05-31 20:07           ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=447DF38E.3020409@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=aabdulla@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=willy@w.ods.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).