From: Auke Kok <auke-jan.h.kok@intel.com>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: Amit Arora <aarora@in.ibm.com>, Auke Kok <sofar@foo-projects.org>,
netdev@vger.kernel.org, amitarora@in.ibm.com
Subject: Re: DPRINTKs in e1000 code (2.6.x kernels)
Date: Thu, 01 Jun 2006 15:22:26 -0700 [thread overview]
Message-ID: <447F68A2.20605@intel.com> (raw)
In-Reply-To: <447F654A.3040406@intel.com>
Auke Kok wrote:
> Amit Arora wrote:
>> On Wed, 2006-05-31 at 16:30, Auke Kok wrote:
>>> On Wed, 31 May 2006 14:31:05 +0530, Amit K Arora <aarora@in.ibm.com>
>>> wrote:
>>>> Should these DPRINTKs be removed from the 2.6.x e1000 code as well ?
>>> they already are. the patch was merged in 7.0.38-k2 or so which is
>>> over a month ago.
>>
>> I do not think these DPRINTKs have been removed from the latest code.
>> Or, they did get removed at some point of time, but somehow again got
>> added.
>> I checked in 2.16.17-rc4 kernel, and also in the following versions of
>> e1000 codebase (pulled from
>> git://lost.foo-projects.org/~ahkok/git/netdev-2.6):
>> e1000-7.0.38-k1, -k2 ... -k5 e1000-7.0.41
>>
>> All of the above versions have the concerned DPRINTKs in e1000_suspend()
>> and other routines.
>>
>> Please check once and let me know if I am missing something. Thanks!
>
> git-show d0e027db7861ef03de0ac08494a9a61984d8f8b0
>
> it's really in there - please use jgarzik's netdev#upstream branch. Not
> sure if it already made it to 2.16.17-rc5, but I don't think this made
> it into 2.16.17-rc4, so that is where you may be missing it.
I'm in need of coffee - these changes got queued for 2.6.18. They're in
jgarziks netdev-2.6.git, but not anywhere in 2.6.17rcX
Auke
next prev parent reply other threads:[~2006-06-01 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-31 9:01 DPRINTKs in e1000 code (2.6.x kernels) Amit K Arora
2006-05-31 23:30 ` Auke Kok
2006-06-01 21:57 ` Amit Arora
2006-06-01 22:08 ` Auke Kok
2006-06-01 22:22 ` Auke Kok [this message]
2006-06-01 10:04 ` Amit K Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447F68A2.20605@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=aarora@in.ibm.com \
--cc=amitarora@in.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sofar@foo-projects.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).