From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Drake Subject: Re: [linux-usb-devel] [PATCH RFC] ZyDAS ZD1211 USB-WLAN driver Date: Sun, 04 Jun 2006 22:51:08 +0100 Message-ID: <448355CC.3030401@gentoo.org> References: <44817083.508@gentoo.org> <200606040025.32275.oliver@neukum.org> <200606041917.55496.oliver@neukum.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Oliver Neukum , John Que , linux-usb-devel@lists.sourceforge.net, "John W. Linville" , netdev@vger.kernel.org, Ulrich Kunitz Return-path: Received: from mta07-winn.ispmail.ntl.com ([81.103.221.47]:26806 "EHLO mtaout01-winn.ispmail.ntl.com") by vger.kernel.org with ESMTP id S932277AbWFDVuj (ORCPT ); Sun, 4 Jun 2006 17:50:39 -0400 To: Rami Rosen In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Rami Rosen wrote: > It is mentioned there that these definitions are taken from the ZYDAS > driver and not all of them are relevant for the rewrite driver; > however, it seems to me that > removing them may be thought of. They are mostly relevant, not all come from the vendor driver directly, some will be used later, many are useful for documenting the bits and bobs that we *do* know about the CR registers (not a lot). I don't think there are any readability issues while all defines are kept out of the way from the code. Daniel