From: Larry Finger <Larry.Finger@lwfinger.net>
To: netdev@vger.kernel.org, John Linville <linville@tuxdriver.com>
Subject: PATCH to correct dump of WPA IE
Date: Thu, 08 Jun 2006 09:47:42 -0500 [thread overview]
Message-ID: <4488388E.1080309@lwfinger.net> (raw)
In net/ieee80211/softmac/ieee80211softmac_wx.c, there is a bug that prints extended sign information
whenever the byte value exceeds 0x7f. The following patch changes the printk to use a u8 cast to
limit the output to 2 digits. This bug was first noticed by Dan Williams <dcbw@redhat.com>. This
patch applies to the current master branch of the Linville tree.
Signed-Off-By: Larry Finger <Larry.Finger@lwfinger.net>
diff --git a/net/ieee80211/softmac/ieee80211softmac_wx.c b/net/ieee80211/softmac/ieee80211softmac_wx.c
index 27edb2b..55c5c26 100644
--- a/net/ieee80211/softmac/ieee80211softmac_wx.c
+++ b/net/ieee80211/softmac/ieee80211softmac_wx.c
@@ -388,7 +388,7 @@ ieee80211softmac_wx_set_genie(struct net
memcpy(mac->wpa.IE, extra, wrqu->data.length);
dprintk(KERN_INFO PFX "generic IE set to ");
for (i=0;i<wrqu->data.length;i++)
- dprintk("%.2x", mac->wpa.IE[i]);
+ dprintk("%.2x", (u8)mac->wpa.IE[i]);
dprintk("\n");
mac->wpa.IElen = wrqu->data.length;
} else {
reply other threads:[~2006-06-08 14:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4488388E.1080309@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).