From: Jeff Garzik <jeff@garzik.org>
To: akpm@osdl.org
Cc: netdev@vger.kernel.org, bunk@stusta.de
Subject: Re: [patch 6/8] drivers/char/hw_random.c: remove assert()'s
Date: Fri, 09 Jun 2006 10:19:35 -0400 [thread overview]
Message-ID: <44898377.2090602@garzik.org> (raw)
In-Reply-To: <200606090519.k595JlHj032029@shell0.pdx.osdl.net>
akpm@osdl.org wrote:
> From: Adrian Bunk <bunk@stusta.de>
>
> Remove the assert()'s from drivers/char/hw_random.c since you both needed
> to enable a manual option in the driver source to make them effective and
> they only covered some obviously impossible cases.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
100% NAK. They are there, obviously, for driver debugging and
development. Just like libata's debug stuff, you certainly have to
enable them manually.
Until this driver goes away (real soon, right?), the debugging facility
should stay.
Jeff
prev parent reply other threads:[~2006-06-09 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-09 5:19 [patch 6/8] drivers/char/hw_random.c: remove assert()'s akpm
2006-06-09 14:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44898377.2090602@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).