* [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support
@ 2006-06-14 23:22 Randy Dunlap
2006-06-15 11:32 ` Stefano Brivio
2006-06-15 15:41 ` Arjan van de Ven
0 siblings, 2 replies; 8+ messages in thread
From: Randy Dunlap @ 2006-06-14 23:22 UTC (permalink / raw)
To: lkml, netdev; +Cc: mb, akpm
From: Matthew Garrett <mjg59@srcf.ucam.org>
Broadcom wireless patch, PCIE/Mactel support
http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1373a8487e911b5ee204f4422ddea00929c8a4cc
This patch adds support for PCIE cores to the bcm43xx driver. This is
needed for wireless to work on the Intel imacs. I've submitted it to
bcm43xx upstream.
(cherry picked from d88edf6a433074323a1805365a8dfc9c26fceae3 commit)
(cherry picked from 7dbd83ed3255fde4371edcbb6ad1d30f3e6ddf08 commit)
---
--- a/drivers/net/wireless/bcm43xx/bcm43xx.h
+++ b/drivers/net/wireless/bcm43xx/bcm43xx.h
@@ -202,6 +202,8 @@
#define BCM43xx_COREID_USB20_HOST 0x819
#define BCM43xx_COREID_USB20_DEV 0x81a
#define BCM43xx_COREID_SDIO_HOST 0x81b
+#define BCM43xx_COREID_PCIE 0x820
+#define BCM43xx_COREID_CHIPCOMMON_NEW 0x900
/* Core Information Registers */
#define BCM43xx_CIR_BASE 0xf00
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -130,6 +130,8 @@ MODULE_PARM_DESC(fwpostfix, "Postfix for
{ PCI_VENDOR_ID_BROADCOM, 0x4301, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
/* Broadcom 4307 802.11b */
{ PCI_VENDOR_ID_BROADCOM, 0x4307, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+ /* Broadcom 4312 80211a/b/g */
+ { PCI_VENDOR_ID_BROADCOM, 0x4312, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
/* Broadcom 4318 802.11b/g */
{ PCI_VENDOR_ID_BROADCOM, 0x4318, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
/* Broadcom 4319 802.11a/b/g */
@@ -2580,7 +2582,8 @@ static int bcm43xx_probe_cores(struct bc
core_vendor = (sb_id_hi & 0xFFFF0000) >> 16;
/* if present, chipcommon is always core 0; read the chipid from it */
- if (core_id == BCM43xx_COREID_CHIPCOMMON) {
+ if (core_id == BCM43xx_COREID_CHIPCOMMON ||
+ core_id == BCM43xx_COREID_CHIPCOMMON_NEW) {
chip_id_32 = bcm43xx_read32(bcm, 0);
chip_id_16 = chip_id_32 & 0xFFFF;
bcm->core_chipcommon.available = 1;
@@ -2614,7 +2617,8 @@ static int bcm43xx_probe_cores(struct bc
/* ChipCommon with Core Rev >=4 encodes number of cores,
* otherwise consult hardcoded table */
- if ((core_id == BCM43xx_COREID_CHIPCOMMON) && (core_rev >= 4)) {
+ if (((core_id == BCM43xx_COREID_CHIPCOMMON) && (core_rev >= 4)) ||
+ core_id == BCM43xx_COREID_CHIPCOMMON_NEW) {
core_count = (chip_id_32 & 0x0F000000) >> 24;
} else {
switch (chip_id_16) {
@@ -2686,6 +2690,7 @@ static int bcm43xx_probe_cores(struct bc
core = NULL;
switch (core_id) {
case BCM43xx_COREID_PCI:
+ case BCM43xx_COREID_PCIE:
core = &bcm->core_pci;
if (core->available) {
printk(KERN_WARNING PFX "Multiple PCI cores found.\n");
@@ -2724,6 +2729,7 @@ static int bcm43xx_probe_cores(struct bc
case 6:
case 7:
case 9:
+ case 10:
break;
default:
printk(KERN_ERR PFX "Error: Unsupported 80211 core revision %u\n",
@@ -3002,7 +3008,7 @@ static int bcm43xx_setup_backplane_pci_c
if (err)
goto out;
- if (bcm->core_pci.rev < 6) {
+ if (bcm->core_pci.rev < 6 && bcm->core_pci.id != BCM43xx_COREID_PCIE) {
value = bcm43xx_read32(bcm, BCM43xx_CIR_SBINTVEC);
value |= (1 << backplane_flag_nr);
bcm43xx_write32(bcm, BCM43xx_CIR_SBINTVEC, value);
@@ -3024,7 +3030,7 @@ static int bcm43xx_setup_backplane_pci_c
value |= BCM43xx_SBTOPCI2_PREFETCH | BCM43xx_SBTOPCI2_BURST;
bcm43xx_write32(bcm, BCM43xx_PCICORE_SBTOPCI2, value);
- if (bcm->core_pci.rev < 5) {
+ if (bcm->core_pci.rev < 5 && bcm->core_pci.id != BCM43xx_COREID_PCIE) {
value = bcm43xx_read32(bcm, BCM43xx_CIR_SBIMCONFIGLOW);
value |= (2 << BCM43xx_SBIMCONFIGLOW_SERVICE_TOUT_SHIFT)
& BCM43xx_SBIMCONFIGLOW_SERVICE_TOUT_MASK;
@@ -3351,7 +3357,7 @@ static int bcm43xx_read_phyinfo(struct b
bcm->ieee->freq_band = IEEE80211_24GHZ_BAND;
break;
case BCM43xx_PHYTYPE_G:
- if (phy_rev > 7)
+ if (phy_rev > 8)
phy_rev_ok = 0;
bcm->ieee->modulation = IEEE80211_OFDM_MODULATION |
IEEE80211_CCK_MODULATION;
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support
2006-06-14 23:22 [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support Randy Dunlap
@ 2006-06-15 11:32 ` Stefano Brivio
2006-06-15 14:07 ` Michael Buesch
` (2 more replies)
2006-06-15 15:41 ` Arjan van de Ven
1 sibling, 3 replies; 8+ messages in thread
From: Stefano Brivio @ 2006-06-15 11:32 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, netdev, mb, akpm
On Wed, 14 Jun 2006 16:22:39 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Matthew Garrett <mjg59@srcf.ucam.org>
>
> Broadcom wireless patch, PCIE/Mactel support
>
> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1373a8487e911b5ee204f4422ddea00929c8a4cc
>
> This patch adds support for PCIE cores to the bcm43xx driver. This is
> needed for wireless to work on the Intel imacs. I've submitted it to
> bcm43xx upstream.
NACK.
This has been superseded by my patchset:
http://www.mail-archive.com/bcm43xx-dev@lists.berlios.de/msg01267.html
I'm still waiting for more testing so I didn't request merging to mainline
yet. Plus, this patch is copied from this one:
http://www.mail-archive.com/bcm43xx-dev@lists.berlios.de/msg00919.html
which is wrong. Please see my patchset and new specs for reference.
PS: Next time, don't be rude and send patches to the maintainers.
--
Ciao
Stefano
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support
2006-06-15 11:32 ` Stefano Brivio
@ 2006-06-15 14:07 ` Michael Buesch
2006-06-15 17:12 ` Randy Dunlap
2006-06-29 19:55 ` John W. Linville
2 siblings, 0 replies; 8+ messages in thread
From: Michael Buesch @ 2006-06-15 14:07 UTC (permalink / raw)
To: Stefano Brivio; +Cc: Randy Dunlap, lkml, netdev, mb, akpm
On Thursday 15 June 2006 13:32, Stefano Brivio wrote:
> On Wed, 14 Jun 2006 16:22:39 -0700
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
> > From: Matthew Garrett <mjg59@srcf.ucam.org>
> >
> > Broadcom wireless patch, PCIE/Mactel support
> >
> > http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1373a8487e911b5ee204f4422ddea00929c8a4cc
> >
> > This patch adds support for PCIE cores to the bcm43xx driver. This is
> > needed for wireless to work on the Intel imacs. I've submitted it to
> > bcm43xx upstream.
>
> NACK.
> This has been superseded by my patchset:
> http://www.mail-archive.com/bcm43xx-dev@lists.berlios.de/msg01267.html
>
> I'm still waiting for more testing so I didn't request merging to mainline
> yet. Plus, this patch is copied from this one:
> http://www.mail-archive.com/bcm43xx-dev@lists.berlios.de/msg00919.html
> which is wrong. Please see my patchset and new specs for reference.
I told by local computer stuff distributor to order a PCIe card.
He was not able to find one, yet. But I would like to test the patch
first. Well, if someone could tell me the exact name of a bcm43xx PCIe
card, it would be easier, perhaps.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support
2006-06-15 11:32 ` Stefano Brivio
2006-06-15 14:07 ` Michael Buesch
@ 2006-06-15 17:12 ` Randy Dunlap
2006-06-29 19:55 ` John W. Linville
2 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2006-06-15 17:12 UTC (permalink / raw)
To: Stefano Brivio; +Cc: lkml, netdev, mb, akpm
Stefano Brivio wrote:
> On Wed, 14 Jun 2006 16:22:39 -0700
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
>> From: Matthew Garrett <mjg59@srcf.ucam.org>
>>
>> Broadcom wireless patch, PCIE/Mactel support
>>
>> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1373a8487e911b5ee204f4422ddea00929c8a4cc
>>
>> This patch adds support for PCIE cores to the bcm43xx driver. This is
>> needed for wireless to work on the Intel imacs. I've submitted it to
>> bcm43xx upstream.
>
> NACK.
> This has been superseded by my patchset:
> http://www.mail-archive.com/bcm43xx-dev@lists.berlios.de/msg01267.html
>
> I'm still waiting for more testing so I didn't request merging to mainline
> yet. Plus, this patch is copied from this one:
> http://www.mail-archive.com/bcm43xx-dev@lists.berlios.de/msg00919.html
> which is wrong. Please see my patchset and new specs for reference.
>
> PS: Next time, don't be rude and send patches to the maintainers.
Noted.
Thanks for your comments.
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support
2006-06-15 11:32 ` Stefano Brivio
2006-06-15 14:07 ` Michael Buesch
2006-06-15 17:12 ` Randy Dunlap
@ 2006-06-29 19:55 ` John W. Linville
2006-06-29 20:04 ` Michael Buesch
2 siblings, 1 reply; 8+ messages in thread
From: John W. Linville @ 2006-06-29 19:55 UTC (permalink / raw)
To: Stefano Brivio; +Cc: Randy Dunlap, lkml, netdev, mb, akpm
On Thu, Jun 15, 2006 at 01:32:20PM +0200, Stefano Brivio wrote:
> On Wed, 14 Jun 2006 16:22:39 -0700
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
> > From: Matthew Garrett <mjg59@srcf.ucam.org>
> >
> > Broadcom wireless patch, PCIE/Mactel support
> >
> > http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1373a8487e911b5ee204f4422ddea00929c8a4cc
> >
> > This patch adds support for PCIE cores to the bcm43xx driver. This is
> > needed for wireless to work on the Intel imacs. I've submitted it to
> > bcm43xx upstream.
>
> NACK.
> This has been superseded by my patchset:
> http://www.mail-archive.com/bcm43xx-dev@lists.berlios.de/msg01267.html
>
> I'm still waiting for more testing so I didn't request merging to mainline
Are these patches coming soon?
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support
2006-06-29 19:55 ` John W. Linville
@ 2006-06-29 20:04 ` Michael Buesch
0 siblings, 0 replies; 8+ messages in thread
From: Michael Buesch @ 2006-06-29 20:04 UTC (permalink / raw)
To: John W. Linville; +Cc: Stefano Brivio, Randy Dunlap, lkml, netdev, mb, akpm
On Thursday 29 June 2006 21:55, John W. Linville wrote:
> On Thu, Jun 15, 2006 at 01:32:20PM +0200, Stefano Brivio wrote:
> > On Wed, 14 Jun 2006 16:22:39 -0700
> > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> >
> > > From: Matthew Garrett <mjg59@srcf.ucam.org>
> > >
> > > Broadcom wireless patch, PCIE/Mactel support
> > >
> > > http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1373a8487e911b5ee204f4422ddea00929c8a4cc
> > >
> > > This patch adds support for PCIE cores to the bcm43xx driver. This is
> > > needed for wireless to work on the Intel imacs. I've submitted it to
> > > bcm43xx upstream.
> >
> > NACK.
> > This has been superseded by my patchset:
> > http://www.mail-archive.com/bcm43xx-dev@lists.berlios.de/msg01267.html
> >
> > I'm still waiting for more testing so I didn't request merging to mainline
>
> Are these patches coming soon?
No, we don't have hardware to test it.
So if someone knows a PCIe Broadcom WLAN card... ;)
--
Greetings Michael.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support
2006-06-14 23:22 [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support Randy Dunlap
2006-06-15 11:32 ` Stefano Brivio
@ 2006-06-15 15:41 ` Arjan van de Ven
2006-06-16 5:39 ` Randy Dunlap
1 sibling, 1 reply; 8+ messages in thread
From: Arjan van de Ven @ 2006-06-15 15:41 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, netdev, mb, akpm
On Wed, 2006-06-14 at 16:22 -0700, Randy Dunlap wrote:
> From: Matthew Garrett <mjg59@srcf.ucam.org>
>
> Broadcom wireless patch, PCIE/Mactel support
>
> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1373a8487e911b5ee204f4422ddea00929c8a4cc
>
> This patch adds support for PCIE cores to the bcm43xx driver. This is
> needed for wireless to work on the Intel imacs. I've submitted it to
> bcm43xx upstream.
who's signing off on these patches??
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support
2006-06-15 15:41 ` Arjan van de Ven
@ 2006-06-16 5:39 ` Randy Dunlap
0 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2006-06-16 5:39 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: lkml, netdev, mb, akpm
Arjan van de Ven wrote:
> On Wed, 2006-06-14 at 16:22 -0700, Randy Dunlap wrote:
>> From: Matthew Garrett <mjg59@srcf.ucam.org>
>>
>> Broadcom wireless patch, PCIE/Mactel support
>>
>> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1373a8487e911b5ee204f4422ddea00929c8a4cc
>>
>> This patch adds support for PCIE cores to the bcm43xx driver. This is
>> needed for wireless to work on the Intel imacs. I've submitted it to
>> bcm43xx upstream.
>
>
> who's signing off on these patches??
Well, this particular one isn't going anywhere AFAIK, so it doesn't matter here.
For most of them, Ben Collins or someone else at Ubuntu has signed-off on them
(although not so on this one).
Let's continue the general discussion on the "reviewing" thread.
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-06-29 20:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-14 23:22 [Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support Randy Dunlap
2006-06-15 11:32 ` Stefano Brivio
2006-06-15 14:07 ` Michael Buesch
2006-06-15 17:12 ` Randy Dunlap
2006-06-29 19:55 ` John W. Linville
2006-06-29 20:04 ` Michael Buesch
2006-06-15 15:41 ` Arjan van de Ven
2006-06-16 5:39 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).