From: "Arnd Bergmann" <arnd@arndb.de>
To: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: Netdev <netdev@vger.kernel.org>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Grygorii Strashko" <grygorii.strashko@ti.com>,
"Murali Karicheri" <m-karicheri2@ti.com>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"Ioana Ciornei" <ioana.ciornei@nxp.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"Kevin Hao" <haokexin@gmail.com>,
"Daniel Zahka" <daniel.zahka@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] [v4, net-next] net: ethernet: ti-cpsw:: rename soft_reset() function
Date: Thu, 02 Apr 2026 21:16:29 +0200 [thread overview]
Message-ID: <4498f664-15ca-4859-a050-a593f124105f@app.fastmail.com> (raw)
In-Reply-To: <CAC_iWj+vjZ0WnKUuqeFfaPeSoj5ovxZiEmUD5R8hPsRfkqMihQ@mail.gmail.com>
On Thu, Apr 2, 2026, at 21:13, Ilias Apalodimas wrote:
> Hi Arnd,
>
> On Thu, 2 Apr 2026 at 21:47, Arnd Bergmann <arnd@kernel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> While looking at the glob symbols shared between the cpsw drivers,
>> I noticed that soft_reset() is the only one that is missing a proper
>> namespace prefix, and will pollute the kernel namespace, so rename
>> it to be consistent with the other symbols.
>>
>> Fixes: c5013ac1dd0e1 ("net: ethernet: ti: cpsw: move set of common functions in cpsw_priv")
>
> The patch seems fine, but why the Fixes: tag?
Before the c5013ac1dd0e1 commit, this was a 'static inline' function,
which is allowed to clash with other identifiers. Making it a global
symbol during the move was a problem.
Arnd
next prev parent reply other threads:[~2026-04-02 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 18:46 [PATCH 1/3] [v4, net-next] net: ethernet: ti-cpsw:: rename soft_reset() function Arnd Bergmann
2026-04-02 18:46 ` [PATCH 2/3] [v4, net-next] net: ethernet: ti-cpsw: fix linking built-in code to modules Arnd Bergmann
2026-04-02 18:46 ` [PATCH 3/3] [v4, net-next] dpaa2: avoid linking objects into multiple modules Arnd Bergmann
2026-04-02 19:13 ` [PATCH 1/3] [v4, net-next] net: ethernet: ti-cpsw:: rename soft_reset() function Ilias Apalodimas
2026-04-02 19:16 ` Arnd Bergmann [this message]
2026-04-04 9:11 ` Simon Horman
2026-04-05 19:31 ` Arnd Bergmann
2026-04-07 2:05 ` Jakub Kicinski
2026-04-07 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4498f664-15ca-4859-a050-a593f124105f@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexander.sverdlin@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@kernel.org \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=haokexin@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox