From: John Daiker <jdaiker@osdl.org>
To: netdev@vger.kernel.org
Cc: akpm@osdl.org, jgarzik@pobox.com
Subject: Kernel Janitor TODO: dev_kfree_skb
Date: Fri, 23 Jun 2006 10:35:53 -0700 [thread overview]
Message-ID: <449C2679.6020501@osdl.org> (raw)
I was running through the kernel janitors TODO list
(http://janitor.kernelnewbies.org/TODO) and thought I'd try to find
something easy for my first attempt at kernel hacking/maintenance.
The "Balancing Function" header suggests that all net_device interrupt
functions should use dev_kfree_skb_irq as opposed to dev_kfree_skb.
Should we ever be calling dev_kfree_skb directly, or would the better
practice be to always call dev_kfree_skb_any (thus letting the kernel
decide to call dev_kfree_skb or dev_kfree_skb_irq)?
dev_kfree_skb_any is defined in 'net/core/dev.c:1118'
John Daiker
next reply other threads:[~2006-06-23 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 17:35 John Daiker [this message]
2006-06-23 23:47 ` Kernel Janitor TODO: dev_kfree_skb Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449C2679.6020501@osdl.org \
--to=jdaiker@osdl.org \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).