From: Jeff Garzik <jeff@garzik.org>
To: akpm@osdl.org
Cc: netdev@vger.kernel.org, Uwe_Zeisberger@digi.com, afleming@freescale.com
Subject: Re: [patch 3/3] Fix phy id for LXT971A/LXT972A
Date: Sun, 25 Jun 2006 05:15:29 -0400 [thread overview]
Message-ID: <449E5431.3020904@garzik.org> (raw)
In-Reply-To: <200606250844.k5P8ichl020797@shell0.pdx.osdl.net>
akpm@osdl.org wrote:
> From: Uwe Zeisberger <Uwe_Zeisberger@digi.com>
>
> The phy ids used are taken from an driver that used a right shift of 4 to chop
> off the revision number. This driver does not shift, so the id and mask
> values are wrong and must be left shifted by 4 to actually detect the chips.
>
> Signed-off-by: Uwe Zeisberger <Uwe_Zeisberger@digi.com>
> Acked-by: Andy Fleming <afleming@freescale.com>
>
> [akpm: this is a previously-nacked patch, but the problem is real]
> Signed-off-by: Andrew Morton <akpm@osdl.org>
This was nak'd? Does anyone recall why?
Jeff
next prev parent reply other threads:[~2006-06-25 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-25 8:44 [patch 3/3] Fix phy id for LXT971A/LXT972A akpm
2006-06-25 9:15 ` Jeff Garzik [this message]
2006-06-25 9:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449E5431.3020904@garzik.org \
--to=jeff@garzik.org \
--cc=Uwe_Zeisberger@digi.com \
--cc=afleming@freescale.com \
--cc=akpm@osdl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).