From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 13/21] e1000: add E1000_BIG_ENDIAN symbol Date: Mon, 26 Jun 2006 21:49:50 -0400 Message-ID: <44A08EBE.7030104@pobox.com> References: <20060622051815.25497.89192.stgit@gitlost.site> <20060622052034.25497.81683.stgit@gitlost.site> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "Brandeburg, Jesse" , "Kok, Auke" , "Ronciak, John" Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:43476 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1030600AbWF0Btw (ORCPT ); Mon, 26 Jun 2006 21:49:52 -0400 To: "Kok, Auke" In-Reply-To: <20060622052034.25497.81683.stgit@gitlost.site> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Kok, Auke wrote: > This adds a private symbol to signify endianess in our driver. > > Signed-off-by: Jesse Brandeburg > Signed-off-by: Auke Kok > --- > > drivers/net/e1000/e1000_hw.h | 2 +- > drivers/net/e1000/e1000_osdep.h | 3 +++ > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/e1000/e1000_hw.h b/drivers/net/e1000/e1000_hw.h > index 941b47d..376a2ef 100644 > --- a/drivers/net/e1000/e1000_hw.h > +++ b/drivers/net/e1000/e1000_hw.h > @@ -351,7 +351,7 @@ struct e1000_host_mng_command_info { > struct e1000_host_mng_command_header command_header; /* Command Head/Command Result Head has 4 bytes */ > uint8_t command_data[E1000_HI_MAX_MNG_DATA_LENGTH]; /* Command data can length 0..0x658*/ > }; > -#ifdef __BIG_ENDIAN > +#ifdef E1000_BIG_ENDIAN > struct e1000_host_mng_dhcp_cookie{ > uint32_t signature; > uint16_t vlan_id; > diff --git a/drivers/net/e1000/e1000_osdep.h b/drivers/net/e1000/e1000_osdep.h > index 048d052..6130a42 100644 > --- a/drivers/net/e1000/e1000_osdep.h > +++ b/drivers/net/e1000/e1000_osdep.h > @@ -83,6 +83,9 @@ typedef enum { > #define DEBUGOUT3 DEBUGOUT2 > #define DEBUGOUT7 DEBUGOUT3 > > +#ifdef __BIG_ENDIAN > +#define E1000_BIG_ENDIAN __BIG_ENDIAN > +#endif NAK. This is backwards: We don't need wrappers for symbols that the kernel already provides. Jeff