From: John Haller <jhaller@lucent.com>
To: Brent Cook <bcook@bpointsys.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] mv643xx fixes - Disable interrupts on all ports during initialization
Date: Tue, 27 Jun 2006 10:16:28 -0500 [thread overview]
Message-ID: <44A14BCC.5060708@lucent.com> (raw)
In-Reply-To: <200606270951.59024.bcook@bpointsys.com>
Brent Cook wrote:
> This patch disable interrupts on all ports during initialization. The current
> assumes that the firmware has already disabled all interrupts on all ports.
> We have encountered some boards that do not always disable interrupts (XES
> XPedite 6200 for instance) on a soft reset. This patch prevents a kernel
> panic if a packet is received before the DMA ring buffers are setup for a
> port on which interrupts are left enabled by the firmware.
You probably have bigger problems than the interrupt being left
enabled. If the interrupt is left enabled, the DMA engine
is probably left enabled, and if a packet happens
to come in before the driver can properly configure them,
some random part of memory will get overwritten.
The firmware needs to disable this device before transferring
control to the kernel, both the interrupts and the DMA,
there is no way to fix this in the kernel.
next prev parent reply other threads:[~2006-06-27 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 14:51 [PATCH 1/3] mv643xx fixes - Disable interrupts on all ports during initialization Brent Cook
2006-06-27 15:16 ` John Haller [this message]
2006-06-27 16:09 ` Nathaniel Case
2006-06-30 16:20 ` Jeff Garzik
2006-07-03 18:11 ` Brent Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A14BCC.5060708@lucent.com \
--to=jhaller@lucent.com \
--cc=bcook@bpointsys.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).