netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] d80211: Take lowlevel driver's channel change time into account during scanning.
@ 2006-07-01 20:40 Gertjan van Wingerde
  2006-07-03 11:58 ` Jiri Benc
  0 siblings, 1 reply; 2+ messages in thread
From: Gertjan van Wingerde @ 2006-07-01 20:40 UTC (permalink / raw)
  To: netdev; +Cc: Jiri Benc, jkmaline, linville

Make the dscape stack take the driver-supplied channel change time into 
account when actively scanning for networks.
This particularly has been a problem in the rt2x00 driver, where 
configuration changes are done via a work-queue, and
the subsequent channel changes failed due to the dscape stack scheduling 
a channel update while the previous one had not
been performed yet, resulting in failed scans.

Signed-off-by: Gertjan van Wingerde <gwingerde@kpnplanet.nl>

diff --git a/net/d80211/ieee80211_sta.c b/net/d80211/ieee80211_sta.c
index 37d40aa..9f8653d 100644
--- a/net/d80211/ieee80211_sta.c
+++ b/net/d80211/ieee80211_sta.c
@@ -2503,7 +2503,8 @@ #endif
                        break;
                }

-               local->scan_timer.expires = jiffies + IEEE80211_PROBE_DELAY;
+               local->scan_timer.expires = jiffies + IEEE80211_PROBE_DELAY +
+                             usecs_to_jiffies(local->hw->channel_change_time);
                local->scan_state = SCAN_SEND_PROBE;
                break;
        case SCAN_SEND_PROBE:





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] d80211: Take lowlevel driver's channel change time into account during scanning.
  2006-07-01 20:40 [PATCH] d80211: Take lowlevel driver's channel change time into account during scanning Gertjan van Wingerde
@ 2006-07-03 11:58 ` Jiri Benc
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Benc @ 2006-07-03 11:58 UTC (permalink / raw)
  To: Gertjan van Wingerde; +Cc: netdev, jkmaline, linville

On Sat, 01 Jul 2006 22:40:38 +0200, Gertjan van Wingerde wrote:
> Make the dscape stack take the driver-supplied channel change time into 
> account when actively scanning for networks.
> This particularly has been a problem in the rt2x00 driver, where 
> configuration changes are done via a work-queue, and
> the subsequent channel changes failed due to the dscape stack scheduling 
> a channel update while the previous one had not
> been performed yet, resulting in failed scans.

Your mail client converts tabs to spaces. Nevertheless, I applied the
patch to my git tree.

Thanks for fixing this,

 Jiri

-- 
Jiri Benc
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-07-03 11:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-01 20:40 [PATCH] d80211: Take lowlevel driver's channel change time into account during scanning Gertjan van Wingerde
2006-07-03 11:58 ` Jiri Benc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).