* [patch 7/9] 8139cp.c printk fix
@ 2006-07-07 6:58 akpm
2006-07-07 7:38 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: akpm @ 2006-07-07 6:58 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm
From: Andrew Morton <akpm@osdl.org>
drivers/net/8139cp.c: In function 'cp_init_one':
drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'resource_size_t'
drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'resource_size_t'
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
drivers/net/8139cp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/8139cp.c~8139cp-printk-fix drivers/net/8139cp.c
--- a/drivers/net/8139cp.c~8139cp-printk-fix
+++ a/drivers/net/8139cp.c
@@ -1916,7 +1916,7 @@ static int cp_init_one (struct pci_dev *
regs = ioremap(pciaddr, CP_REGS_SIZE);
if (!regs) {
rc = -EIO;
- dev_err(&pdev->dev, "Cannot map PCI MMIO (%lx@%lx)\n",
+ dev_err(&pdev->dev, "Cannot map PCI MMIO (%Lx@%Lx)\n",
(unsigned long long)pci_resource_len(pdev, 1),
(unsigned long long)pciaddr);
goto err_out_res;
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 7/9] 8139cp.c printk fix
2006-07-07 6:58 [patch 7/9] 8139cp.c printk fix akpm
@ 2006-07-07 7:38 ` Jeff Garzik
2006-07-07 7:54 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2006-07-07 7:38 UTC (permalink / raw)
To: akpm; +Cc: netdev
akpm@osdl.org wrote:
> From: Andrew Morton <akpm@osdl.org>
>
> drivers/net/8139cp.c: In function 'cp_init_one':
> drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'resource_size_t'
> drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'resource_size_t'
>
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> drivers/net/8139cp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/net/8139cp.c~8139cp-printk-fix drivers/net/8139cp.c
> --- a/drivers/net/8139cp.c~8139cp-printk-fix
> +++ a/drivers/net/8139cp.c
> @@ -1916,7 +1916,7 @@ static int cp_init_one (struct pci_dev *
> regs = ioremap(pciaddr, CP_REGS_SIZE);
> if (!regs) {
> rc = -EIO;
> - dev_err(&pdev->dev, "Cannot map PCI MMIO (%lx@%lx)\n",
> + dev_err(&pdev->dev, "Cannot map PCI MMIO (%Lx@%Lx)\n",
> (unsigned long long)pci_resource_len(pdev, 1),
> (unsigned long long)pciaddr);
should be %llx if I'm not mistaken... (looks like a merge screwup on my
part)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 7/9] 8139cp.c printk fix
2006-07-07 7:38 ` Jeff Garzik
@ 2006-07-07 7:54 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-07-07 7:54 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
On Fri, 07 Jul 2006 03:38:21 -0400
Jeff Garzik <jeff@garzik.org> wrote:
> akpm@osdl.org wrote:
> > From: Andrew Morton <akpm@osdl.org>
> >
> > drivers/net/8139cp.c: In function 'cp_init_one':
> > drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'resource_size_t'
> > drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'resource_size_t'
> >
> >
> > Signed-off-by: Andrew Morton <akpm@osdl.org>
> > ---
> >
> > drivers/net/8139cp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -puN drivers/net/8139cp.c~8139cp-printk-fix drivers/net/8139cp.c
> > --- a/drivers/net/8139cp.c~8139cp-printk-fix
> > +++ a/drivers/net/8139cp.c
> > @@ -1916,7 +1916,7 @@ static int cp_init_one (struct pci_dev *
> > regs = ioremap(pciaddr, CP_REGS_SIZE);
> > if (!regs) {
> > rc = -EIO;
> > - dev_err(&pdev->dev, "Cannot map PCI MMIO (%lx@%lx)\n",
> > + dev_err(&pdev->dev, "Cannot map PCI MMIO (%Lx@%Lx)\n",
> > (unsigned long long)pci_resource_len(pdev, 1),
> > (unsigned long long)pciaddr);
>
> should be %llx if I'm not mistaken... (looks like a merge screwup on my
> part)
%llx == %Lx (doesn't it?)
It saves a byte ;)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-07-07 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-07 6:58 [patch 7/9] 8139cp.c printk fix akpm
2006-07-07 7:38 ` Jeff Garzik
2006-07-07 7:54 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).