From: Jeff Garzik <jeff@garzik.org>
To: akpm@osdl.org
Cc: netdev@vger.kernel.org, dtor@insightbb.com, dtor@mail.ru
Subject: Re: [patch 8/9] smsc-ircc2: fix section reference mismatches
Date: Fri, 07 Jul 2006 13:28:16 -0400 [thread overview]
Message-ID: <44AE99B0.6040508@garzik.org> (raw)
In-Reply-To: <200607070658.k676wRh5030383@shell0.pdx.osdl.net>
akpm@osdl.org wrote:
> From: Dmitry Torokhov <dtor@insightbb.com>
>
> subsystem_configurations array is only used by an __init function,
> therefore it should be marked __initdata, not __devinitdata.
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> drivers/net/irda/smsc-ircc2.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches drivers/net/irda/smsc-ircc2.c
> --- a/drivers/net/irda/smsc-ircc2.c~smsc-ircc2-fix-section-reference-mismatches
> +++ a/drivers/net/irda/smsc-ircc2.c
> @@ -2353,7 +2353,7 @@ static int __init smsc_superio_lpc(unsig
> #ifdef CONFIG_PCI
> #define PCIID_VENDOR_INTEL 0x8086
> #define PCIID_VENDOR_ALI 0x10b9
> -static struct smsc_ircc_subsystem_configuration subsystem_configurations[] __devinitdata = {
> +static struct smsc_ircc_subsystem_configuration subsystem_configurations[] __initdata = {
Are you sure this fully solves the problem?
It seems like the functions referenced inside this are inappropriately
marked as well...
next prev parent reply other threads:[~2006-07-07 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 6:58 [patch 8/9] smsc-ircc2: fix section reference mismatches akpm
2006-07-07 17:28 ` Jeff Garzik [this message]
2006-07-07 19:53 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AE99B0.6040508@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=dtor@insightbb.com \
--cc=dtor@mail.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).