From: Michael Tokarev <mjt@tls.msk.ru>
To: Robert Schulze <rob@net-pr.de>
Cc: Dan Williams <dcbw@redhat.com>,
netdev@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()
Date: Sun, 09 Jul 2006 21:55:41 +0400 [thread overview]
Message-ID: <44B1431D.3010405@tls.msk.ru> (raw)
In-Reply-To: <44B13974.9090604@net-pr.de>
Robert Schulze wrote:
> Hi,
>
> Dan Williams schrieb:
>> This message will only happen if the card hangs up and stops responding
>> to commands anyway, so we don't necessarily care about making the
>> message decipherable to anyone other than developers.
>
> Well, I get this message each time I insert my Cisco Aironet 350 PCMCIA
> card, which works obviously fine.
[]
> Besides, the messages can be read by issuing dmesg even after the patch,
> so no information gets lost.
The fact that you're getting that message indicates that something's wrong,
at least from the kernel's point of view. So it better be understand and
fixed, instead of being hidden in debugging output. If it's visible in
dmesg but isn't visible in syslog (default syslog configuration does not
capture any debugging messages), far less people will notice it.
I'd vote for making it one-line, but with current KERN_ERR priority.
/mjt (who don't even have the hardware in question)
next prev parent reply other threads:[~2006-07-09 17:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-08 15:59 [PATCH] airo: make debug-like messages printed by airo_print_dbg() Robert Schulze
2006-07-09 14:24 ` Dan Williams
2006-07-09 17:14 ` Robert Schulze
2006-07-09 17:55 ` Michael Tokarev [this message]
2006-07-09 22:23 ` Robert Schulze
2006-07-10 3:12 ` Dan Williams
2006-07-10 16:37 ` Robert Schulze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B1431D.3010405@tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=dcbw@redhat.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rob@net-pr.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).