netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ixgb: fix tx unit hang - properly calculate desciptor count
@ 2006-07-10 15:51 Auke Kok
  0 siblings, 0 replies; only message in thread
From: Auke Kok @ 2006-07-10 15:51 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Andrew Morton, NetDev, Jesse Brandeburg, Auke Kok

[-- Attachment #1: Type: text/plain, Size: 61 bytes --]


Jeff,

Please apply to #upstream-fixes.

Cheers,

Auke

---

[-- Attachment #2: ixgb_fix_tx_hang_ring_overrun.patch --]
[-- Type: text/x-patch, Size: 1280 bytes --]

There were some tso bugs that only showed up with heavy load and 16kB
pages that this patch fixes by making the driver's internal use count
of descriptors match the count that it was estimating it needed using
the DESC_NEEDED macro.  This bug caused NETDEV_WATCHDOG resets aka
tx timeouts.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>

---

 drivers/net/ixgb/ixgb_main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
index b91e082..846e11b 100644
--- a/drivers/net/ixgb/ixgb_main.c
+++ b/drivers/net/ixgb/ixgb_main.c
@@ -1281,7 +1281,7 @@ ixgb_tx_map(struct ixgb_adapter *adapter
 
 	while(len) {
 		buffer_info = &tx_ring->buffer_info[i];
-		size = min(len, IXGB_MAX_JUMBO_FRAME_SIZE);
+		size = min(len, IXGB_MAX_DATA_PER_TXD);
 		buffer_info->length = size;
 		buffer_info->dma =
 			pci_map_single(adapter->pdev,
@@ -1306,7 +1306,7 @@ ixgb_tx_map(struct ixgb_adapter *adapter
 
 		while(len) {
 			buffer_info = &tx_ring->buffer_info[i];
-			size = min(len, IXGB_MAX_JUMBO_FRAME_SIZE);
+			size = min(len, IXGB_MAX_DATA_PER_TXD);
 			buffer_info->length = size;
 			buffer_info->dma =
 				pci_map_page(adapter->pdev,

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-07-10 15:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-10 15:51 [PATCH] ixgb: fix tx unit hang - properly calculate desciptor count Auke Kok

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).