From: Robert Schulze <rob@net-pr.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Dan Williams <dcbw@redhat.com>,
netdev@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()
Date: Mon, 10 Jul 2006 18:37:44 +0200 [thread overview]
Message-ID: <44B28258.2060109@net-pr.de> (raw)
In-Reply-To: <44B1431D.3010405@tls.msk.ru>
Hi,
I regret making a mistake yesterday, I forgot a comma.
Here now is the working patch.
[PATCH] airo: collapse debugging-messages in issuecommand to one line
Robert Schulze
--- linux-2.6.17.1/drivers/net/wireless/airo.c.orig 2006-07-08 14:02:12.000000000 +0200
+++ linux-2.6.17.1/drivers/net/wireless/airo.c 2006-07-10 18:30:30.000000000 +0200
@@ -3897,11 +3897,10 @@ static u16 issuecommand(struct airo_info
pRsp->rsp1 = IN4500(ai, RESP1);
pRsp->rsp2 = IN4500(ai, RESP2);
if ((pRsp->status & 0xff00)!=0 && pCmd->cmd != CMD_SOFTRESET) {
- airo_print_err(ai->dev->name, "cmd= %x\n", pCmd->cmd);
- airo_print_err(ai->dev->name, "status= %x\n", pRsp->status);
- airo_print_err(ai->dev->name, "Rsp0= %x\n", pRsp->rsp0);
- airo_print_err(ai->dev->name, "Rsp1= %x\n", pRsp->rsp1);
- airo_print_err(ai->dev->name, "Rsp2= %x\n", pRsp->rsp2);
+ airo_print_err(ai->dev->name,
+ "cmd:%x status:%x rsp0:%x rsp1:%x rsp2:%x",
+ pCmd->cmd, pRsp->status, pRsp->rsp0, pRsp->rsp1,
+ pRsp->rsp2);
}
// clear stuck command busy if necessary
prev parent reply other threads:[~2006-07-10 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-08 15:59 [PATCH] airo: make debug-like messages printed by airo_print_dbg() Robert Schulze
2006-07-09 14:24 ` Dan Williams
2006-07-09 17:14 ` Robert Schulze
2006-07-09 17:55 ` Michael Tokarev
2006-07-09 22:23 ` Robert Schulze
2006-07-10 3:12 ` Dan Williams
2006-07-10 16:37 ` Robert Schulze [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B28258.2060109@net-pr.de \
--to=rob@net-pr.de \
--cc=dcbw@redhat.com \
--cc=linville@tuxdriver.com \
--cc=mjt@tls.msk.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).