* [PATCH] sky2: NAPI poll fix
@ 2006-07-17 13:54 Stephen Hemminger
2006-07-17 17:27 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2006-07-17 13:54 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
When sky2 driver gets lots of received packets at once, it can get stuck.
The NAPI poll routine gets called back to keep going, but since no IRQ bits
are set it doesn't make progress.
Increase version, since this is serious enough problem that I want to be
able to tell new from old problems.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- sky2.orig/drivers/net/sky2.c 2006-07-17 06:02:27.000000000 -0700
+++ sky2/drivers/net/sky2.c 2006-07-17 06:06:56.000000000 -0700
@@ -50,7 +50,7 @@
#include "sky2.h"
#define DRV_NAME "sky2"
-#define DRV_VERSION "1.4"
+#define DRV_VERSION "1.5"
#define PFX DRV_NAME " "
/*
@@ -2204,9 +2204,6 @@
int work_done = 0;
u32 status = sky2_read32(hw, B0_Y2_SP_EISR);
- if (!~status)
- goto out;
-
if (status & Y2_IS_HW_ERR)
sky2_hw_intr(hw);
@@ -2243,7 +2240,7 @@
if (sky2_more_work(hw))
return 1;
-out:
+
netif_rx_complete(dev0);
sky2_read32(hw, B0_Y2_SP_LISR);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sky2: NAPI poll fix
2006-07-17 13:54 [PATCH] sky2: NAPI poll fix Stephen Hemminger
@ 2006-07-17 17:27 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-07-17 17:27 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
Stephen Hemminger wrote:
> When sky2 driver gets lots of received packets at once, it can get stuck.
> The NAPI poll routine gets called back to keep going, but since no IRQ bits
> are set it doesn't make progress.
>
> Increase version, since this is serious enough problem that I want to be
> able to tell new from old problems.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-17 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-17 13:54 [PATCH] sky2: NAPI poll fix Stephen Hemminger
2006-07-17 17:27 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).