From: Guillaume Chazarain <guichaz@yahoo.fr>
To: chas3@users.sourceforge.net
Cc: David Miller <davem@davemloft.net>,
herbert@gondor.apana.org.au, shemminger@osdl.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] clear skb cb on IP input
Date: Tue, 18 Jul 2006 20:19:34 +0200 [thread overview]
Message-ID: <44BD2636.1010105@yahoo.fr> (raw)
In-Reply-To: <200607161120.k6GBKZEG009486@cmf.nrl.navy.mil>
chas williams - CONTRACTOR wrote:
> why does the input side of the ip layer believe the cb contains valid
> data? it should zero the contents of the cb, or just fill in the cb
> correctly when the packet arrives at its doorstop.
>
Why not clearing the whole IPCB(skb) instead of
just IPCB(skb)->opts? that would also clear
IPCB(skb)->flags.
And, does not ipv6 need the same treatment with
IP6CB?
Regards.
--
Guillaume
next prev parent reply other threads:[~2006-07-18 18:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-14 14:34 Netem does not work with loopback Guillaume Chazarain
2006-07-14 15:38 ` Stephen Hemminger
2006-07-14 17:04 ` Guillaume Chazarain
2006-07-14 18:39 ` Stephen Hemminger
2006-07-14 18:49 ` Guillaume Chazarain
2006-07-14 18:56 ` [PATCH] clear skb cb on IP input Stephen Hemminger
2006-07-14 21:48 ` David Miller
2006-07-15 13:28 ` Herbert Xu
2006-07-15 15:50 ` Stephen Hemminger
2006-07-16 1:15 ` David Miller
2006-07-16 1:12 ` David Miller
2006-07-16 11:20 ` chas williams - CONTRACTOR
2006-07-17 2:02 ` David Miller
2006-07-18 18:19 ` Guillaume Chazarain [this message]
2006-07-18 19:43 ` Herbert Xu
2006-07-19 12:35 ` Guillaume Chazarain
2006-07-25 6:45 ` David Miller
2006-07-16 22:03 ` Herbert Xu
2006-07-17 1:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44BD2636.1010105@yahoo.fr \
--to=guichaz@yahoo.fr \
--cc=chas3@users.sourceforge.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).