From: Shuya MAEDA <maeda-sxb@necst.nec.co.jp>
To: Guillaume Chazarain <guichaz@yahoo.fr>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: Patch "[PKT_SCHED]: PSCHED_TADD() and PSCHED_TADD2() can result,tv_usec >= 1000000" seems wrong
Date: Wed, 19 Jul 2006 16:49:11 +0900 [thread overview]
Message-ID: <44BDE3F7.4000507@necst.nec.co.jp> (raw)
In-Reply-To: <44B7A76C.4010703@yahoo.fr>
Hello.
> In PSCHED_TADD2, if delta is less than tv.tv_usec (so, less than
> USEC_PER_SEC too) then tv_res will be before tv. The
> affectation (tv_res).tv_usec = __delta; is wrong. The same applies to
> PSCHED_TADD.
You are right. It is my mistake.
> I think the correct fix is simply to restore the original code and
> change the 'if' in a 'while'.
In Guillaume's patch,
"while (__delta > USEC_PER_SEC){ ... }", but I think it should be
"while (__delta >= USEC_PER_SEC){ ... }". Is it right?
Thank you very much.
--
Shuya MAEDA
next prev parent reply other threads:[~2006-07-19 7:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-14 14:17 Patch "[PKT_SCHED]: PSCHED_TADD() and PSCHED_TADD2() can result,tv_usec >= 1000000" seems wrong Guillaume Chazarain
2006-07-19 7:49 ` Shuya MAEDA [this message]
2006-07-19 12:47 ` Guillaume Chazarain
2006-07-24 6:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44BDE3F7.4000507@necst.nec.co.jp \
--to=maeda-sxb@necst.nec.co.jp \
--cc=davem@davemloft.net \
--cc=guichaz@yahoo.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).