Re: [PATCH] Qlogic qla3xxx driver v2.02.00-k36 for upstream inclusion.

Re: [PATCH] Qlogic qla3xxx driver v2.02.00-k36 for upstream inclusion.

[Jeff Garzik]

Ron Mercer wrote:
>  
> Andrew,
> 
> Attached is a patch to the qla3xxx driver in your -mm test kernel.  This 
> patch makes the following changes:
> 
> -Removed potential infinite loop in ql_sem_spinlock().
> -Relaxed hardware locking granularity.
> -Fixed irq_request() where shared flag was used in MSI environment.
> -Removed queue containing TX control blocks. This resource has a one to 
> one  correspondence to each entry in the TX queue.
> -Removed unnecessary tx_lock.
> -Changed version to v2.02.00-k36.
> 
> The above changes plus the changes from the k35 patch address Jeff 
> Garzik's concerns from his response. His response can be reviewed at 
> this URL:
> 
> http://marc.theaimsgroup.com/?l=linux-netdev&m=115101855424635&w=2 
> <http://marc.theaimsgroup.com/?l=linux-netdev&m=115101855424635&w=2>
> 
> 
> 
> This driver has been through several iterations on the netdev list and 
> we feel this driver is ready for inclusion in the upstream kernel.

Send me a patch via private email (for size reasons), include a proper 
Signed-off-by line per http://linux.yyz.us/patch-format.html and I will 
merge this driver straightaway.

	Jeff

Re: [PATCH] Qlogic qla3xxx driver v2.02.00-k36 for upstream inclusion.

[Michael Tokarev]

By the way, should it work with ISP4010 controllers?
Those "expose" network interface card "subdevice" too,
but aren't listed in pci_device_table of the driver,
and after adding the device ID to the driver, it still
does not quite work (I tried, just out of curiosity) -
the NIC on ISP4010 is - it seems - close but not exactly
the same as the driver expects.

Thanks.

/mjt

RE: [PATCH] Qlogic qla3xxx driver v2.02.00-k36 for upstream inclusion.

[Ron Mercer]

qla3xxx driver  does not support ISP4010.

> -----Original Message-----
> From: Michael Tokarev [mailto:mjt@tls.msk.ru] 
> Sent: Thursday, July 20, 2006 2:13 AM
> To: Ron Mercer
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH] Qlogic qla3xxx driver v2.02.00-k36 for 
> upstream inclusion.
> 
> By the way, should it work with ISP4010 controllers?
> Those "expose" network interface card "subdevice" too, but 
> aren't listed in pci_device_table of the driver, and after 
> adding the device ID to the driver, it still does not quite 
> work (I tried, just out of curiosity) - the NIC on ISP4010 is 
> - it seems - close but not exactly the same as the driver expects.
> 
> Thanks.
> 
> /mjt
> 

Re: [PATCH] Qlogic qla3xxx driver v2.02.00-k36 for upstream inclusion.

[Andrew Vasquez]

On Thu, 20 Jul 2006, Ron Mercer wrote:

> qla3xxx driver  does not support ISP4010.

Exactly...  The qla3xxx driver supports the NIC function only.

> > -----Original Message-----
> > From: Michael Tokarev [mailto:mjt@tls.msk.ru] 
> > Sent: Thursday, July 20, 2006 2:13 AM
> > To: Ron Mercer
> > Cc: netdev@vger.kernel.org
> > Subject: Re: [PATCH] Qlogic qla3xxx driver v2.02.00-k36 for 
> > upstream inclusion.
> > 
> > By the way, should it work with ISP4010 controllers?
> > Those "expose" network interface card "subdevice" too, but 
> > aren't listed in pci_device_table of the driver, and after 
> > adding the device ID to the driver, it still does not quite 
> > work (I tried, just out of curiosity) - the NIC on ISP4010 is 
> > - it seems - close but not exactly the same as the driver expects.

You'll need to use the qla4xxx driver to drive the iSCSI function.

Regards,
Andrew Vasquez

Re: [PATCH] Qlogic qla3xxx driver v2.02.00-k36 for upstream inclusion.

[Michael Tokarev]

Andrew Vasquez wrote:
> On Thu, 20 Jul 2006, Ron Mercer wrote:
> 
>> qla3xxx driver  does not support ISP4010.
> 
> Exactly...  The qla3xxx driver supports the NIC function only.

...which is provided by ISP4010 card, as appears on PCI bus:

04:04.0 Ethernet controller: QLogic Corp. QLA3010 Network Adapter (rev 05)
04:04.1 Network controller: QLogic Corp. QLA4010 iSCSI TOE Adapter (rev 05)

(the first (sub)device).  So it *looks* like the card has *both*
a NIC and iSCSI TOE adapter, and the NIC part is pretty much similar
to what qla3xxx driver expects...  That's why my curiosity. ;)

(not that it matters much, just.. curious, really.
Well.  Not exactly.  It'd be nice to compare a NIC w/o Jumbo
frames support (which we have on all machines connected to
the iSCSI segment), with something more.. advanced.  So I
wondered if I can utilize the NIC part of the ISP4010 for
the test.  iSCSI part of the card works significantly slower
than open-iscsi stack on non-jumbo-frames-aware Tigon GigE NIC).

[]
> You'll need to use the qla4xxx driver to drive the iSCSI function.

Yeah, I know.  I posted some results to open-iscsi@ list about a week
ago.  It basically works (the new one, with open-iscsi infrastructure),
but is slooow... ;)

Thanks.

/mjt