netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas DICHTEL <nicolas.dichtel@6wind.com>
To: hadi@cyberus.ca
Cc: netdev@vger.kernel.org
Subject: Re: Oops in IFB
Date: Thu, 20 Jul 2006 16:31:16 +0200	[thread overview]
Message-ID: <44BF93B4.3030204@6wind.com> (raw)
In-Reply-To: <44BF934F.8050708@6wind.com>

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Sorry, I forgot the patch ;-)

Nicolas

Nicolas DICHTEL a écrit :
> jamal a écrit :
>> BTW, in the name of the LinuxWay(tm) - can you also submit a similar
>> patch for dummy? It suffers from the same bug.
> No problem, patch is enclosed.
>
> Cheers,
> Nicolas
>
> [DUMMY] Avoid an oops when dummy_init_one() failed
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

[-- Attachment #2: x.diff --]
[-- Type: text/x-patch, Size: 285 bytes --]

--- a/drivers/net/dummy.c	2006-07-20 16:19:09.395351558 +0200
+++ b/drivers/net/dummy.c	2006-07-20 16:19:58.802327279 +0200
@@ -132,6 +132,7 @@
 	for (i = 0; i < numdummies && !err; i++)
 		err = dummy_init_one(i); 
 	if (err) { 
+		i--;
 		while (--i >= 0)
 			dummy_free_one(i);
 	}

  reply	other threads:[~2006-07-20 14:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-20 13:33 Oops in IFB Nicolas DICHTEL
2006-07-20 13:40 ` jamal
2006-07-20 13:58   ` jamal
2006-07-20 14:29     ` Nicolas DICHTEL
2006-07-20 14:31       ` Nicolas DICHTEL [this message]
2006-07-20 23:17         ` David Miller
2006-07-20 23:16   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44BF93B4.3030204@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=hadi@cyberus.ca \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).