netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Auke Kok <auke-jan.h.kok@intel.com>
To: Theodore Tso <tytso@mit.edu>, Andrew Morton <akpm@osdl.org>,
	Auke Kok <auke-jan.h.kok@intel.com>,
	pavel@ucw.cz, cramerj@intel.com, john.ronciak@intel.com,
	jesse.brandeburg@intel.com, jeffrey.t.kirsher@intel.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: e1000: "fix" it on thinkpad x60 / eeprom checksum read fails
Date: Fri, 21 Jul 2006 08:22:38 -0700	[thread overview]
Message-ID: <44C0F13E.2030008@intel.com> (raw)
In-Reply-To: <20060721151239.GC2290@thunk.org>

Theodore Tso wrote:
> On Fri, Jul 21, 2006 at 06:41:05AM -0700, Andrew Morton wrote:
>>> It's completely not acceptable to run when the EEPROM checksum fails - you 
>>> might even be running with the wrong MAC address, or worse. Lets fix this the 
>>> right way instead.
>> A printk which helps the user to understand all this saga would be very nice.
>> -
> 
> And if someone who understands all of these details could put a note
> in the thinkwiki (say, here:
> http://www.thinkwiki.org/wiki/Ethernet_Controllers#Intel_Gigabit_.2810.2F100.2F1000.29)
> it would be greatly appreciated.
> 

why don't I do that :)


Andrew: I'm contemplating that printk...


Cheers,

Auke

  reply	other threads:[~2006-07-21 15:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060721005832.GA1889@elf.ucw.cz>
     [not found] ` <44BFADA6.6090909@intel.com>
     [not found]   ` <20060720170758.GA9938@atrey.karlin.mff.cuni.cz>
2006-07-20 17:34     ` e1000: "fix" it on thinkpad x60 / eeprom checksum read fails Auke Kok
2006-07-21 13:41       ` Andrew Morton
2006-07-21 15:12         ` Theodore Tso
2006-07-21 15:22           ` Auke Kok [this message]
2006-07-22  0:21             ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44C0F13E.2030008@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=akpm@osdl.org \
    --cc=cramerj@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).