* [PATCH] skge: chip clock rate typo
[not found] <200607222330.30842.mb@bu3sch.de>
@ 2006-07-19 20:35 ` Stephen Hemminger
2006-07-19 21:08 ` Stephen Hemminger
2006-07-24 21:34 ` Larry Finger
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2006-07-19 20:35 UTC (permalink / raw)
To: Michael Buesch, Jeff Garzik; +Cc: netdev
Michael Buesch spotted this typo. The impact is that the incorrect value
was being computed for blinking LED and interrupt moderation values.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- skge-2.6.orig/drivers/net/skge.c
+++ skge-2.6/drivers/net/skge.c
@@ -519,7 +519,7 @@ static inline u32 hwkhz(const struct skg
if (hw->chip_id == CHIP_ID_GENESIS)
return 53215; /* or: 53.125 MHz */
else
- return 78215; /* or: 78.125 MHz */
+ return 78125; /* or: 78.125 MHz */
}
/* Chip HZ to microseconds */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] skge: chip clock rate typo
2006-07-24 21:34 ` Larry Finger
@ 2006-07-19 21:03 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2006-07-19 21:03 UTC (permalink / raw)
To: Larry Finger; +Cc: Michael Buesch, Jeff Garzik, netdev
On Mon, 24 Jul 2006 16:34:46 -0500
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Stephen Hemminger wrote:
> > Michael Buesch spotted this typo. The impact is that the incorrect value
> > was being computed for blinking LED and interrupt moderation values.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> >
> > --- skge-2.6.orig/drivers/net/skge.c
> > +++ skge-2.6/drivers/net/skge.c
> > @@ -519,7 +519,7 @@ static inline u32 hwkhz(const struct skg
> > if (hw->chip_id == CHIP_ID_GENESIS)
> > return 53215; /* or: 53.125 MHz */
> -------------------------^ Should this be 53125?
>
> Larry
>
yup
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] skge: chip clock rate typo
2006-07-19 20:35 ` [PATCH] skge: chip clock rate typo Stephen Hemminger
@ 2006-07-19 21:08 ` Stephen Hemminger
2006-07-24 21:34 ` Larry Finger
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2006-07-19 21:08 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Michael Buesch, Jeff Garzik, netdev
Okay, Fix both typo's in one patch .The impact is that the incorrect value
was being computed for blinking LED and interrupt moderation values.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- skge-2.6.orig/drivers/net/skge.c
+++ skge-2.6/drivers/net/skge.c
@@ -516,10 +516,7 @@ static int skge_set_pauseparam(struct ne
/* Chip internal frequency for clock calculations */
static inline u32 hwkhz(const struct skge_hw *hw)
{
- if (hw->chip_id == CHIP_ID_GENESIS)
- return 53215; /* or: 53.125 MHz */
- else
- return 78215; /* or: 78.125 MHz */
+ return (hw->chip_id == CHIP_ID_GENESIS) ? 53125 : 78125;
}
/* Chip HZ to microseconds */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] skge: chip clock rate typo
2006-07-19 20:35 ` [PATCH] skge: chip clock rate typo Stephen Hemminger
2006-07-19 21:08 ` Stephen Hemminger
@ 2006-07-24 21:34 ` Larry Finger
2006-07-19 21:03 ` Stephen Hemminger
1 sibling, 1 reply; 4+ messages in thread
From: Larry Finger @ 2006-07-24 21:34 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Michael Buesch, Jeff Garzik, netdev
Stephen Hemminger wrote:
> Michael Buesch spotted this typo. The impact is that the incorrect value
> was being computed for blinking LED and interrupt moderation values.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>
> --- skge-2.6.orig/drivers/net/skge.c
> +++ skge-2.6/drivers/net/skge.c
> @@ -519,7 +519,7 @@ static inline u32 hwkhz(const struct skg
> if (hw->chip_id == CHIP_ID_GENESIS)
> return 53215; /* or: 53.125 MHz */
-------------------------^ Should this be 53125?
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-07-24 22:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200607222330.30842.mb@bu3sch.de>
2006-07-19 20:35 ` [PATCH] skge: chip clock rate typo Stephen Hemminger
2006-07-19 21:08 ` Stephen Hemminger
2006-07-24 21:34 ` Larry Finger
2006-07-19 21:03 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).