* softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1] [not found] <1153782637.44c5536e013a4@webmail> @ 2006-07-25 0:00 ` Daniel Drake 2006-07-25 0:12 ` Stephen Hemminger 2006-07-25 0:01 ` Daniel Drake 1 sibling, 1 reply; 3+ messages in thread From: Daniel Drake @ 2006-07-25 0:00 UTC (permalink / raw) To: Tom Walter Dillig; +Cc: linux-kernel, w, kernel_org, security, Netdev list Tom Walter Dillig wrote: > [109] > 452 net/ieee80211/softmac/ieee80211softmac_io.c > Possible null dereference of variable "*pkt" in function call > (include/asm/string.h:__constant_c_and_count_memset) checked at > (453:net/ieee80211/softmac/ieee80211softmac_io.c) Either I'm misunderstanding, or this is bogus. when *pkt is allocated by the various child functions (e.g. ieee80211softmac_disassoc_deauth), it is always checked for NULL. Finally, line 453 does another NULL check. What is the report trying to say? Daniel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1] 2006-07-25 0:00 ` softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1] Daniel Drake @ 2006-07-25 0:12 ` Stephen Hemminger 0 siblings, 0 replies; 3+ messages in thread From: Stephen Hemminger @ 2006-07-25 0:12 UTC (permalink / raw) To: Daniel Drake Cc: Tom Walter Dillig, linux-kernel, w, kernel_org, security, Netdev list On Tue, 25 Jul 2006 01:00:54 +0100 Daniel Drake <dsd@gentoo.org> wrote: > Tom Walter Dillig wrote: > > [109] > > 452 net/ieee80211/softmac/ieee80211softmac_io.c > > Possible null dereference of variable "*pkt" in function call > > (include/asm/string.h:__constant_c_and_count_memset) checked at > > (453:net/ieee80211/softmac/ieee80211softmac_io.c) > > Either I'm misunderstanding, or this is bogus. > > when *pkt is allocated by the various child functions (e.g. > ieee80211softmac_disassoc_deauth), it is always checked for NULL. > > Finally, line 453 does another NULL check. > > What is the report trying to say? That the check in 453 should be removed because is unneeded. People who obsess about code coverage care that there are unneded checks. I don't think it matters. ^ permalink raw reply [flat|nested] 3+ messages in thread
* softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1] [not found] <1153782637.44c5536e013a4@webmail> 2006-07-25 0:00 ` softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1] Daniel Drake @ 2006-07-25 0:01 ` Daniel Drake 1 sibling, 0 replies; 3+ messages in thread From: Daniel Drake @ 2006-07-25 0:01 UTC (permalink / raw) To: Tom Walter Dillig; +Cc: linux-kernel, w, kernel_org, security, Netdev list Tom Walter Dillig wrote: > [109] > 452 net/ieee80211/softmac/ieee80211softmac_io.c > Possible null dereference of variable "*pkt" in function call > (include/asm/string.h:__constant_c_and_count_memset) checked at > (453:net/ieee80211/softmac/ieee80211softmac_io.c) Either I'm misunderstanding, or this is bogus. when *pkt is allocated by the various child functions (e.g. ieee80211softmac_disassoc_deauth), it is always checked for NULL before being used. Finally, line 453 does another NULL check, so that any failures generated above are handled appropriately. What is the report trying to say? Daniel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-07-25 0:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1153782637.44c5536e013a4@webmail>
2006-07-25 0:00 ` softmac possible null deref [was: Complete report of Null dereference errors in kernel 2.6.17.1] Daniel Drake
2006-07-25 0:12 ` Stephen Hemminger
2006-07-25 0:01 ` Daniel Drake
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).