netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/7] Updated patchset w/James' comments
@ 2006-07-17 15:52 paul.moore
  2006-07-17 15:52 ` [PATCH 1/7] NetLabel: documentation paul.moore
                   ` (7 more replies)
  0 siblings, 8 replies; 35+ messages in thread
From: paul.moore @ 2006-07-17 15:52 UTC (permalink / raw)
  To: netdev, selinux; +Cc: davem, sds, jmorris, pratt

Some changes in the patchset based on James Morris' comments over the weekend, in
addition I rebased the patchset against 2.6.18-rc2.  For those who want/need some
background and missed my posting last week I have pasted the announcement below.

Once again, please consider this patchset for inclusion into the 2.6.19 kernel.

Thanks.

--
I am posting this patchset for consideration and inclusion into the 2.6.19
kernel, it is against 2.6.18-rc1 [now rebased against 2.6.18-rc2].

This patchset introduces NetLabel, a implementation of explicit packet
labeling (i.e. CIPSO), to the Linux kernel.  NetLabel has been designed to
have as minimal an impact on the base networking stack as possible; this
includes both code changes as well as performance.  I, as well as many others
who have posted to various lists on earlier NetLabel patches, believe that an
interoperable form of labeled networking is important for Linux's success in
the Trusted OS arena currently being dominated by commercial UNIX systems.
DaveM, I know you have previously posted that you feel CIPSO does not belong
in the Linux kernel on principle, however, I'm hoping the arguments posted
in response have softened your position ...

Earlier versions of this patchset have been posted to the netdev, SELinux,
LSM and RH-LSPP mailing lists over the past couple of months.  It now contains
several rounds of comments and has been tested on a variety of architectures
by people on the RH-LSPP mailing list over the course of the last several
weeks.

If accepted into the mainline kernel, both HP and myself pledge to maintain
this code.

 - Notes on Performance

This past week there was a thread on the RH-LSPP list where the performance of
the NetLabel patch was measured and discussed using the 2.6.17 kernel.  A copy
of the discussion can be found here:

 * http://www.redhat.com/archives/redhat-lspp/2006-July/msg00063.html

With the conclusion being that performance should not be an issue.

Unfortunately the vanilla 2.6.18-rc1 kernel has problems on the two machines
I use for performance testing so I am not currently able to update the
NetLabel performance numbers for 2.6.18-rc1.

 - Notes on Interoperability Testing

The NetLabel CIPSO implementation has been tested against Trusted Solaris and
HP-UX CMW without problems.

 - Instructions for Testing

For those of you wishing to test this patchset you will need the latest
release of the netlabel_tools tarball found here:

 * http://free.linux.hp.com/~pmoore/projects/linux_cipso

You also may want to make use of the "toy policy module" for SELinux which has
been posted to the RH-LSPP mailing list, the archived message can be found
here:

 * http://www.redhat.com/archives/redhat-lspp/2006-June/msg00243.html

Thanks.

--
paul moore
linux security @ hp

^ permalink raw reply	[flat|nested] 35+ messages in thread
* RE: [PATCH 2/7] NetLabel: core network changes
@ 2006-07-31 12:43 Venkat Yekkirala
  2006-07-31 14:16 ` Paul Moore
  0 siblings, 1 reply; 35+ messages in thread
From: Venkat Yekkirala @ 2006-07-31 12:43 UTC (permalink / raw)
  To: Paul Moore; +Cc: David Miller, netdev, selinux, sds, jmorris, pratt

> The NetLabel patch allows administrators to assign specific a CIPSO 
> DOI/configuration to each LSM "domain".  Blindly using the 
> CIPSO tag that the 
> remote host sends could violate the administrator's NetLabel 
> configuration.  
> 
> The current patch reads the CIPSO tag off the child socket, 
> translating the 
> tag according to the CIPSO DOI configuration to arrive at the 
> correct/desired 
> LSM  security attributes.  These LSM security attributes and 
> the "domain" are 
> then used to set the NetLabel on the socket.  In the case 
> where everyone is 
> well behaved this should have no effect on the socket IP 
> options and the 
> packets sent across the wire.  However, in the case of a 
> not-nice remote host 
> the outgoing CIPSO tag may change to match the administrators desired 
> settings.

I wonder if waiting till accept isn't too late though. Perhaps this
should be done when the openreq is created so the syn-ack and such
will go out with the right tag?

^ permalink raw reply	[flat|nested] 35+ messages in thread
* RE: [PATCH 2/7] NetLabel: core network changes
@ 2006-07-29 16:34 Venkat Yekkirala
  2006-07-29 21:03 ` Paul Moore
  0 siblings, 1 reply; 35+ messages in thread
From: Venkat Yekkirala @ 2006-07-29 16:34 UTC (permalink / raw)
  To: Paul Moore, David Miller; +Cc: netdev, selinux, sds, jmorris, pratt

> > This is only true wart I see in the patch set from my
> > perspective.
> > 
> > You have security_post_accept_hook(), which gets the parent and
> > the child socket which is all the information you need, and it
> > seems to be invoked at the correct location.
> > 
> > So can you please hook into this location using the security
> > level hook we already have?  Just check sock->sk->sk_family is
> > PF_INET at the top of that hook if you only want to handle
> > ipv4 sockets, or something like that.
> > 
> > Could this work?
> > 
> > When preparing and argument stating why this won't work, please
> > suggest a nicer name for this af_inet.c hook or some way to make
> > it more generic and palatable to us.
> 
> The only reason for having this new hook in inet_accept() is to catch
> all the in-kernel "daemons" who do not go through the LSM hooked
> accept() code path.  I debated putting this hook into the patchset and
> in the end figured it was at least worth a shot.

If I understand the patch correctly, the openreq inherits cipso from
the incoming syn and the syn-ack is then sent with this option. I further
see that the child sock inherits options from the openreq already.

Could you then please elaborate on the need for explicitly copying options
from parent to child?

^ permalink raw reply	[flat|nested] 35+ messages in thread
* [PATCH 0/7] Latest NetLabel patch for 2.6.19
@ 2006-07-14 18:57 paul.moore
  2006-07-14 18:57 ` [PATCH 2/7] NetLabel: core network changes paul.moore
  0 siblings, 1 reply; 35+ messages in thread
From: paul.moore @ 2006-07-14 18:57 UTC (permalink / raw)
  To: netdev, selinux; +Cc: davem, sds, jmorris, pratt

I am posting this patchset for consideration and inclusion into the 2.6.19
kernel, it is against 2.6.18-rc1.

This patchset introduces NetLabel, a implementation of explicit packet
labeling (i.e. CIPSO), to the Linux kernel.  NetLabel has been designed to
have as minimal an impact on the base networking stack as possible; this
includes both code changes as well as performance.  I, as well as many others
who have posted to various lists on earlier NetLabel patches, believe that an
interoperable form of labeled networking is important for Linux's success in
the Trusted OS arena currently being dominated by commercial UNIX systems.
DaveM, I know you have previously posted that you feel CIPSO does not belong
in the Linux kernel on principle, however, I'm hoping the arguments posted
in response have softened your position ...

Earlier versions of this patchset have been posted to the netdev, SELinux,
LSM and RH-LSPP mailing lists over the past couple of months.  It now contains
several rounds of comments and has been tested on a variety of architectures
by people on the RH-LSPP mailing list over the course of the last several
weeks.

If accepted into the mainline kernel, both HP and myself pledge to maintain
this code.

 - Notes on Performance

This past week there was a thread on the RH-LSPP list where the performance of
the NetLabel patch was measured and discussed using the 2.6.17 kernel.  A copy
of the discussion can be found here:

 * http://www.redhat.com/archives/redhat-lspp/2006-July/msg00063.html

With the conclusion being that performance should not be an issue.

Unfortunately the vanilla 2.6.18-rc1 kernel has problems on the two machines
I use for performance testing so I am not currently able to update the
NetLabel performance numbers for 2.6.18-rc1.

 - Notes on Interoperability Testing

The NetLabel CIPSO implementation has been tested against Trusted Solaris and
HP-UX CMW without problems.

 - Instructions for Testing

For those of you wishing to test this patchset you will need the latest
release of the netlabel_tools tarball found here:

 * http://free.linux.hp.com/~pmoore/projects/linux_cipso

You also may want to make use of the "toy policy module" for SELinux which has
been posted to the RH-LSPP mailing list, the archived message can be found
here:

 * http://www.redhat.com/archives/redhat-lspp/2006-June/msg00243.html

Thanks.

--
paul moore
linux security @ hp

^ permalink raw reply	[flat|nested] 35+ messages in thread

end of thread, other threads:[~2006-07-31 14:17 UTC | newest]

Thread overview: 35+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-17 15:52 [PATCH 0/7] Updated patchset w/James' comments paul.moore
2006-07-17 15:52 ` [PATCH 1/7] NetLabel: documentation paul.moore
2006-07-28  7:51   ` David Miller
2006-07-28 18:52     ` Paul Moore
2006-07-17 15:52 ` [PATCH 2/7] NetLabel: core network changes paul.moore
2006-07-28  7:55   ` David Miller
2006-07-28 18:45     ` Paul Moore
2006-07-28 19:55       ` David Miller
2006-07-28 11:24   ` Thomas Graf
2006-07-28 17:58     ` Paul Moore
2006-07-28 18:12       ` Thomas Graf
2006-07-28 18:39         ` Paul Moore
2006-07-28 18:58           ` Thomas Graf
2006-07-28 19:08             ` Paul Moore
2006-07-28 19:43               ` Evgeniy Polyakov
2006-07-28 19:58               ` David Miller
2006-07-28 20:09                 ` Paul Moore
2006-07-28 20:56                   ` David Miller
2006-07-28 20:59                     ` Paul Moore
2006-07-17 15:52 ` [PATCH 3/7] NetLabel: CIPSOv4 engine paul.moore
2006-07-28  7:56   ` David Miller
2006-07-17 15:52 ` [PATCH 4/7] NetLabel: core NetLabel subsystem paul.moore
2006-07-17 15:52 ` [PATCH 5/7] NetLabel: CIPSOv4 and Unlabeled packet integration paul.moore
2006-07-17 15:52 ` [PATCH 6/7] NetLabel: SELinux support paul.moore
2006-07-17 15:52 ` [PATCH 7/7] NetLabel: tie NetLabel into the Kconfig system paul.moore
2006-07-17 18:48 ` [PATCH 0/7] Updated patchset w/James' comments Valdis.Kletnieks
2006-07-17 19:00   ` Paul Moore
  -- strict thread matches above, loose matches on Subject: below --
2006-07-31 12:43 [PATCH 2/7] NetLabel: core network changes Venkat Yekkirala
2006-07-31 14:16 ` Paul Moore
2006-07-29 16:34 Venkat Yekkirala
2006-07-29 21:03 ` Paul Moore
2006-07-14 18:57 [PATCH 0/7] Latest NetLabel patch for 2.6.19 paul.moore
2006-07-14 18:57 ` [PATCH 2/7] NetLabel: core network changes paul.moore
2006-07-14 23:34   ` James Morris
2006-07-14 23:36     ` David Miller
2006-07-15 14:48     ` Paul Moore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).