From: Masahide NAKAMURA <nakam@linux-ipv6.org>
To: David Miller <davem@davemloft.net>
Cc: yoshfuji@linux-ipv6.org, anttit@tcs.hut.fi, vnuorval@tcs.hut.fi,
netdev@vger.kernel.org, usagi-core@linux-ipv6.org
Subject: Re: [PATCH 22/23] [PATCH] [XFRM] POLICY: Support netlink socket interface for sub policy.
Date: Wed, 02 Aug 2006 10:46:50 +0900 [thread overview]
Message-ID: <44D0040A.6040908@linux-ipv6.org> (raw)
In-Reply-To: <20060801.172403.64001463.davem@davemloft.net>
David Miller wrote:
> From: Masahide NAKAMURA <nakam@linux-ipv6.org>
> Date: Sat, 29 Jul 2006 18:30:55 +0900
>
>> diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h
>> index 901bb65..68d3443 100644
>> --- a/include/linux/xfrm.h
>> +++ b/include/linux/xfrm.h
>> @@ -303,12 +303,14 @@ #define XFRM_POLICY_BLOCK 1
>> __u8 flags;
>> #define XFRM_POLICY_LOCALOK 1 /* Allow user to override global policy */
>> __u8 share;
>> + __u8 type;
>> };
>>
>> struct xfrm_userpolicy_id {
>> struct xfrm_selector sel;
>> __u32 index;
>> __u8 dir;
>> + __u8 type;
>> };
>>
>> struct xfrm_user_acquire {
>
> Again, these are user visible data structures which cannot be
> modified without changing the API. Please use another xfrm
> netlink attribute or similar to pass this information.
I'll try to add XFRMA_POLICY_TYPE for this case.
Thanks,
--
Masahide NAKAMURA
prev parent reply other threads:[~2006-08-02 1:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 9:30 [PATCH 22/23] [PATCH] [XFRM] POLICY: Support netlink socket interface for sub policy Masahide NAKAMURA
2006-08-02 0:24 ` David Miller
2006-08-02 1:46 ` Masahide NAKAMURA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D0040A.6040908@linux-ipv6.org \
--to=nakam@linux-ipv6.org \
--cc=anttit@tcs.hut.fi \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=usagi-core@linux-ipv6.org \
--cc=vnuorval@tcs.hut.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).