From: Masahide NAKAMURA <nakam@linux-ipv6.org>
To: usagi-core@linux-ipv6.org
Cc: yoshfuji@linux-ipv6.org, anttit@tcs.hut.fi, vnuorval@tcs.hut.fi,
netdev@vger.kernel.org
Subject: Re: (usagi-core 30280) Re: [PATCH 10/23] [PATCH] [XFRM]: Trace which secpath state is reject factor.
Date: Wed, 02 Aug 2006 15:07:46 +0900 [thread overview]
Message-ID: <44D04132.3050505@linux-ipv6.org> (raw)
In-Reply-To: <20060801.171501.95894508.davem@davemloft.net>
David Miller wrote:
> From: Masahide NAKAMURA <nakam@linux-ipv6.org>
> Date: Sat, 29 Jul 2006 18:30:29 +0900
>
>> @@ -272,6 +272,9 @@ #define XFRM_TYPE_NON_FRAGMENT 1
>> void (*destructor)(struct xfrm_state *);
>> int (*input)(struct xfrm_state *, struct sk_buff *skb);
>> int (*output)(struct xfrm_state *, struct sk_buff *pskb);
>> +#ifdef CONFIG_XFRM_ADVANCED
>> + int (*reject)(struct xfrm_state *, struct sk_buff *skb, struct flowi *);
>> +#endif
>
> xfrm_secpath_reject() unconditionally dereferences this new reject
> operation pointer, but this patch contains no assignments of it.
>
> Please send incremental patches that are fully functional all by
> themselves, so that if each one is applied, it would compile and
> work.
Thanks, I'll send so next time.
--
Masahide NAKAMURA
prev parent reply other threads:[~2006-08-02 6:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 9:30 [PATCH 10/23] [PATCH] [XFRM]: Trace which secpath state is reject factor Masahide NAKAMURA
2006-08-02 0:15 ` David Miller
2006-08-02 6:07 ` Masahide NAKAMURA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D04132.3050505@linux-ipv6.org \
--to=nakam@linux-ipv6.org \
--cc=anttit@tcs.hut.fi \
--cc=netdev@vger.kernel.org \
--cc=usagi-core@linux-ipv6.org \
--cc=vnuorval@tcs.hut.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).