netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahide NAKAMURA <nakam@linux-ipv6.org>
To: Hugo Santos <hsantos@av.it.pt>
Cc: Masahide NAKAMURA <nakam@linux-ipv6.org>,
	davem@davemloft.net, yoshfuji@linux-ipv6.org, anttit@tcs.hut.fi,
	vnuorval@tcs.hut.fi, netdev@vger.kernel.org,
	usagi-core@linux-ipv6.org
Subject: Re: [RFC] Mobile IPv6 introduction
Date: Wed, 02 Aug 2006 22:03:16 +0900	[thread overview]
Message-ID: <44D0A294.5000208@linux-ipv6.org> (raw)
In-Reply-To: <20060802104756.GN8334@innerghost.net>

Hugo Santos wrote:
>    Although the ICMP-filter approach would be better, it is not flexible
>  enough to handle this situation. We must also send ICMPv6 Parameter
>  Problems when ip6mh_proto isn't IPPROTO_NONE. I don't think it is too

I don't think IPPROTO_NONE case is a suitable example here
(it is also supported by our kernel patch).
We don't have any problem about who checks next header field since its
offset of mobility header never changes then its value
can be checked as the same way for all type number.

But anyway,

>  much of a burthen to handle ICMPv6 in the control daemon because you
>  should already do so to react to ICMPv6 error messages from peers
>  concerning MIPv6 signalling. I'm strongly against doing these checks in
>  the kernel for the simple reason that it is not easily extendable.  You
>  wouldn't be able to deploy a new daemon version over an existing kernel
>  with these changes if it supported a new control protocol with new
>  messages. I think we should follow a different path here and i propose
>  either have a hdrinc=1 mode (for reception only) for protocol raw
>  sockets, possibly adding with control on reception which specifies the
>  offset of the UPL header; or have a control message to obtain the
>  network headers. For instance:
>
>       put_cmsg(msg, SOL_IPV6, ..., (skb->h.raw - skb->nh.raw),
>                skb->nh.raw);

I can agree such suggestion as new kernel feature but I'm not sure
MIPv6 stuff should depend on it just for new message type to extend later.
On our design MIPv6 signaling itself is almost done by user-space daemon.
When developer wants to add new or original type number, it is enough for
kernel to be added the number and its length. All other things can be modified at
user-space application. If there is much requirement to add new type number
without any modification of kernel code at all I would support ICMPv6 filter approach,
too.

-- 
Masahide NAKAMURA

  reply	other threads:[~2006-08-02 13:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29  9:23 [RFC] Mobile IPv6 introduction Masahide NAKAMURA
2006-07-29  9:28 ` [PATCH 0/23][XFRM] MIPv6 CN introduction (part A) (Re: [RFC] Mobile IPv6 introduction) Masahide NAKAMURA
2006-07-29  9:37   ` [PATCH 0/20][IPV6/XFRM] MIPv6 CN (part B) Masahide NAKAMURA
2006-08-02  0:30     ` David Miller
2006-08-02  8:26       ` Masahide NAKAMURA
2006-07-29 14:12 ` [RFC] Mobile IPv6 introduction Hugo Santos
2006-08-02  0:35   ` David Miller
2006-08-02  0:58     ` Hugo Santos
2006-08-02  1:04       ` David Miller
2006-08-02  1:52       ` YOSHIFUJI Hideaki / 吉藤英明
2006-08-02  7:58       ` Ville Nuorvala
2006-08-02 11:03         ` Hugo Santos
2006-08-02  3:24   ` Masahide NAKAMURA
2006-08-02 10:47     ` Hugo Santos
2006-08-02 13:03       ` Masahide NAKAMURA [this message]
2006-08-02 21:14         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44D0A294.5000208@linux-ipv6.org \
    --to=nakam@linux-ipv6.org \
    --cc=anttit@tcs.hut.fi \
    --cc=davem@davemloft.net \
    --cc=hsantos@av.it.pt \
    --cc=netdev@vger.kernel.org \
    --cc=usagi-core@linux-ipv6.org \
    --cc=vnuorval@tcs.hut.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).