From: Philip Craig <philipc@snapgear.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] gre: transparent ethernet bridging
Date: Thu, 03 Aug 2006 11:08:43 +1000 [thread overview]
Message-ID: <44D14C9B.2030706@snapgear.com> (raw)
In-Reply-To: <20060802102337.7ba32020@dxpl.pdx.osdl.net>
Stephen Hemminger wrote:
> On Wed, 02 Aug 2006 16:17:42 +1000
> Philip Craig <philipc@snapgear.com> wrote:
>> It generates a random mac address for gre ports, and also stores
>> a copy of the mac address for ethernet ports, rather than checking
>> dev->type everywhere.
>
> That looks cleaner. I wonder if using a fixed OUI would be better
> than random addresses but then choosing an OUI would be a problem.
random_ether_addr() sets the local assignment bit. This is what
various other virtual devices do (including tap devices, which can
also be bridged).
> You probably should add a comment about what this function is doing,
> and why.
Okay.
next prev parent reply other threads:[~2006-08-03 1:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 10:06 [RFC] gre: transparent ethernet bridging Philip Craig
2006-07-31 16:14 ` Stephen Hemminger
2006-08-01 1:15 ` Philip Craig
2006-08-01 5:08 ` Stephen Hemminger
2006-08-01 9:29 ` Philip Craig
2006-08-02 6:17 ` Philip Craig
2006-08-02 17:23 ` Stephen Hemminger
2006-08-03 1:08 ` Philip Craig [this message]
2006-08-02 7:42 ` Lennert Buytenhek
2006-08-03 1:33 ` Philip Craig
2006-08-03 7:33 ` Lennert Buytenhek
2006-08-03 9:14 ` Philip Craig
2006-08-03 19:40 ` Lennert Buytenhek
2006-08-04 1:00 ` Philip Craig
2006-08-04 8:02 ` Lennert Buytenhek
2006-08-07 1:55 ` Philip Craig
2006-08-10 13:09 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D14C9B.2030706@snapgear.com \
--to=philipc@snapgear.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).