* d80211: bitfield usage should go
@ 2006-08-09 9:07 Jeff Garzik
0 siblings, 0 replies; only message in thread
From: Jeff Garzik @ 2006-08-09 9:07 UTC (permalink / raw)
To: Netdev List
I'm doing an in-depth review of d80211 right now.
One issue that leaps out: use of bitfields.
1) single-bit signed bitfields are undefined
int wep_include_iv:1;
2) bitfields in general generate HORRIBLE code. Just don't use them.
Compilers often fail to use even the most obvious simplifications.
Use flags and bitwise operators instead, like most other Linux code.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-08-09 9:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-09 9:07 d80211: bitfield usage should go Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).