From: Larry Finger <Larry.Finger@lwfinger.net>
To: Dan Williams <dcbw@redhat.com>
Cc: John Linville <linville@tuxdriver.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/8] d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.
Date: Wed, 09 Aug 2006 10:21:16 -0500 [thread overview]
Message-ID: <44D9FD6C.9030006@lwfinger.net> (raw)
In-Reply-To: <1155133346.3615.1.camel@localhost.localdomain>
Dan Williams wrote:
> On Tue, 2006-08-08 at 18:58 -0500, Larry Finger wrote:
>>
>> diff --git a/include/net/d80211.h b/include/net/d80211.h
>> index ba5cb4c..8479b58 100644
>> --- a/include/net/d80211.h
>> +++ b/include/net/d80211.h
>> @@ -205,6 +205,9 @@ struct ieee80211_rx_status {
>> int channel;
>> int phymode;
>> int ssi;
>> + int maxssi;
>> + int signal;
>> + int noise;
>
> Spacing? Looks like you're using real tabs here, but the current code
> uses 8 spaces instead. Not sure if that's a problem.
I am using tabs, which I think is the preferred way. I also remember that the
rule is not to change the white space on things you are not touching. Is that
correct?
Larry
next prev parent reply other threads:[~2006-08-09 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 23:58 [PATCH 1/8] d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics Larry Finger
2006-08-09 14:22 ` Dan Williams
2006-08-09 15:21 ` Larry Finger [this message]
2006-08-09 20:34 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D9FD6C.9030006@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=dcbw@redhat.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).