From: Ville Nuorvala <vnuorval@tcs.hut.fi>
To: David Miller <davem@davemloft.net>
Cc: shemminger@osdl.org, rdreier@cisco.com, netdev@vger.kernel.org
Subject: Re: Excess use of packed attribute
Date: Wed, 09 Aug 2006 22:17:56 +0300 [thread overview]
Message-ID: <44DA34E4.1030501@tcs.hut.fi> (raw)
In-Reply-To: <20060807.162026.106265856.davem@davemloft.net>
David Miller wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Mon, 7 Aug 2006 13:34:23 -0700
>
>> Silly offenders: include/net/ipx.h
>> include/net/ieee80211.h
>> include/net/ip6_tunnel.h
>> include/net/ndisc.h
>> include/linux/if_ether.h
>> include/linux/if_fddi.h
>>
>> include/linux/sctp.h -- really bad
>
> The ndisc.h one, for example, is needed for cases like ARM.
>
> The if_ether.h one is also needed, or else for:
>
> struct ethhdr *eth;
>
> "eth + 1" would do the wrong thing as the compiler would
> align the structure to the native pointer size or similar.
> This is an issue because ethhdr is 14 bytes in size.
Similarly the ipv6_tlv_tnl_enc_lim in ip6_tunnel.h is a 3-octet IPv6
destination sub-option. The sub-option can be located anywhere inside
the destination option header and can only be found by parsing
the whole header.
Regards,
Ville
next prev parent reply other threads:[~2006-08-09 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 20:34 Excess use of packed attribute Stephen Hemminger
2006-08-07 23:20 ` David Miller
2006-08-09 19:17 ` Ville Nuorvala [this message]
2006-08-08 0:02 ` Sridhar Samudrala
2006-08-08 0:39 ` David Miller
2006-08-09 18:37 ` Roland Dreier
2006-08-10 4:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DA34E4.1030501@tcs.hut.fi \
--to=vnuorval@tcs.hut.fi \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).