netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: John Linville <linville@tuxdriver.com>, netdev@vger.kernel.org
Subject: [PATCH] Remove ugly TODO output from log files in bcm43xx-softmac
Date: Wed, 09 Aug 2006 16:13:25 -0500	[thread overview]
Message-ID: <44DA4FF5.4020507@lwfinger.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

This patch removes the ugly TODO output from the logs for bcm43xx-softmac. The
patch is for the latest version of Linville's wireless-2.6 tree.

Signed-Off-By: Larry Finger <Larry.Finger@lwfinger.net>



index b095f3c..d32a9d0 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -1124,9 +1124,9 @@ static void keymac_write(struct bcm43xx_
   				    cpu_to_be16(*((u16 *)(addr + 1))));
   	} else {
   		if (index < 8) {
-			TODO(); /* Put them in the macaddress filter */
+			/*TODO();*/ /* Put them in the macaddress filter */
   		} else {
-			TODO();
+			/*TODO();*/
   			/* Put them BCM43xx_SHM_SHARED, stating index 0x0120.
   			   Keep in mind to update the count of keymacs in 0x003E as well! */
   		}



[-- Attachment #2: patch_todo --]
[-- Type: text/plain, Size: 658 bytes --]

diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
index b095f3c..d32a9d0 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -1124,9 +1124,9 @@ static void keymac_write(struct bcm43xx_
 				    cpu_to_be16(*((u16 *)(addr + 1))));
 	} else {
 		if (index < 8) {
-			TODO(); /* Put them in the macaddress filter */
+			/*TODO();*/ /* Put them in the macaddress filter */
 		} else {
-			TODO();
+			/*TODO();*/
 			/* Put them BCM43xx_SHM_SHARED, stating index 0x0120.
 			   Keep in mind to update the count of keymacs in 0x003E as well! */
 		}



             reply	other threads:[~2006-08-09 21:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-09 21:13 Larry Finger [this message]
2006-08-14 18:55 ` [PATCH] Remove ugly TODO output from log files in bcm43xx-softmac John W. Linville
2006-08-14 19:51   ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44DA4FF5.4020507@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).