[PATCH] Remove ugly TODO output from log files in bcm43xx-softmac

[PATCH] Remove ugly TODO output from log files in bcm43xx-softmac

[Larry Finger]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

This patch removes the ugly TODO output from the logs for bcm43xx-softmac. The
patch is for the latest version of Linville's wireless-2.6 tree.

Signed-Off-By: Larry Finger <Larry.Finger@lwfinger.net>



index b095f3c..d32a9d0 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -1124,9 +1124,9 @@ static void keymac_write(struct bcm43xx_
   				    cpu_to_be16(*((u16 *)(addr + 1))));
   	} else {
   		if (index < 8) {
-			TODO(); /* Put them in the macaddress filter */
+			/*TODO();*/ /* Put them in the macaddress filter */
   		} else {
-			TODO();
+			/*TODO();*/
   			/* Put them BCM43xx_SHM_SHARED, stating index 0x0120.
   			   Keep in mind to update the count of keymacs in 0x003E as well! */
   		}



[-- Attachment #2: patch_todo --]
[-- Type: text/plain, Size: 658 bytes --]

diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
index b095f3c..d32a9d0 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -1124,9 +1124,9 @@ static void keymac_write(struct bcm43xx_
 				    cpu_to_be16(*((u16 *)(addr + 1))));
 	} else {
 		if (index < 8) {
-			TODO(); /* Put them in the macaddress filter */
+			/*TODO();*/ /* Put them in the macaddress filter */
 		} else {
-			TODO();
+			/*TODO();*/
 			/* Put them BCM43xx_SHM_SHARED, stating index 0x0120.
 			   Keep in mind to update the count of keymacs in 0x003E as well! */
 		}

Re: [PATCH] Remove ugly TODO output from log files in bcm43xx-softmac

[John W. Linville]

On Wed, Aug 09, 2006 at 04:13:25PM -0500, Larry Finger wrote:
> This patch removes the ugly TODO output from the logs for bcm43xx-softmac. 
> The
> patch is for the latest version of Linville's wireless-2.6 tree.

I'm not sure if this is the right approach.  In fact I know it isn't --
the right approach would be to implement the missing code! :-)

But barring that, wouldn't it be better to change the TODO() macro
to key off a build-time definition like CONFIG_BCM43XX_DEBUG?

Michael, what do you think?

John
-- 
John W. Linville
linville@tuxdriver.com

Re: [PATCH] Remove ugly TODO output from log files in bcm43xx-softmac

[Michael Buesch]

On Monday 14 August 2006 20:55, John W. Linville wrote:
> On Wed, Aug 09, 2006 at 04:13:25PM -0500, Larry Finger wrote:
> > This patch removes the ugly TODO output from the logs for bcm43xx-softmac. 
> > The
> > patch is for the latest version of Linville's wireless-2.6 tree.
> 
> I'm not sure if this is the right approach.  In fact I know it isn't --
> the right approach would be to implement the missing code! :-)
> 
> But barring that, wouldn't it be better to change the TODO() macro
> to key off a build-time definition like CONFIG_BCM43XX_DEBUG?
> 
> Michael, what do you think?

Heh, well.
Actually the TODO define should have died since months.
BUT: There are still 11 uses of it and they are _all_ valid uses.
_None_ of these should be removed without implementing the code
at the same time.

So, well. What about compiling it to a no-op if BCM43XX_DEBUG is
not defined. I think this is a bad idea.
These TODOs are there for a _very_ good reason. They say:
"If you see this in dmesg, feature foobar does not work at all".
They are a very good hint to the user (and escpecially to the
developers when dealing with "bugreports").

So: If someone would like that a TODO disappears in the logs,
go forward and implement the code. (Actually, most TODOs are
there because of incomplete specifications. But that might have
changed inbetween).

-- 
Greetings Michael.